Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc(0004): update the sync protocol network messages #316

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

doitian
Copy link
Member

@doitian doitian commented Mar 3, 2022

Use the real messages used in the protocol and mark the RFC as Final.

I also changed the category to Informational because this RFC introduces how CKB nodes synchronize the chain but is not a formal specification that can be referenced to create a compatible node.

@doitian doitian requested a review from a team as a code owner March 3, 2022 07:29
@doitian doitian requested a review from zhangsoledad March 3, 2022 07:29
@doitian doitian changed the title rfc(0004): update the network messages. rfc(0004): update the sync protocol network messages Mar 3, 2022
@doitian doitian requested a review from janx March 3, 2022 13:02
zhangsoledad
zhangsoledad previously approved these changes Mar 8, 2022
@doitian doitian added the p:could-have Priority: desirable but not necessary label Apr 1, 2022
janx
janx previously approved these changes Apr 3, 2024
@doitian doitian dismissed stale reviews from janx and zhangsoledad via 30448d4 April 3, 2024 13:50
@doitian doitian force-pushed the revise-rfc0004-sync branch from eb04963 to 30448d4 Compare April 3, 2024 13:50
@doitian doitian requested review from janx and zhangsoledad April 3, 2024 13:51
@janx janx merged commit 198fc90 into nervosnetwork:master Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p:could-have Priority: desirable but not necessary
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants