Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the target sdk version to 34 #36

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Increase the target sdk version to 34 #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2d8d6e4
Increase the target sdk version to 34
pappz Nov 19, 2024
68bdb94
Update artifact version
pappz Nov 19, 2024
3a49a6b
Update go version
pappz Nov 19, 2024
d488dea
- set foreground service type
pappz Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-debug.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v4
with:
go-version: "1.21.x"
go-version: "1.23.3"
- name: Setup Android SDK
uses: android-actions/setup-android@v3
with:
Expand Down Expand Up @@ -62,7 +62,7 @@ jobs:
- name: build debug apk
run: cd android && ./gradlew assembleDebug
- name: upload non tags for debug purposes
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v4
with:
name: debug-apk
path: android/app/build/outputs/apk/debug/app-debug.apk
Expand Down
2 changes: 1 addition & 1 deletion android/app/src/main/java/io/netbird/client/MainApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public ReactNativeHost getReactNativeHost() {
private void registerNotificationReceiver() {
IntentFilter filter = new IntentFilter();
filter.addAction(NetworkChangeNotifier.action);
registerReceiver(notificationReceiver, filter);
registerReceiver(notificationReceiver, filter, RECEIVER_NOT_EXPORTED);
}

@Override
Expand Down
4 changes: 2 additions & 2 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ buildscript {
ext {
buildToolsVersion = "33.0.0"
minSdkVersion = 26
compileSdkVersion = 33
targetSdkVersion = 33
compileSdkVersion = 34
targetSdkVersion = 34

// We use NDK 23 which has both M1 support and is the side-by-side NDK version from AGP.
ndkVersion = "23.1.7779620"
Expand Down
5 changes: 4 additions & 1 deletion android/tool/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.CHANGE_NETWORK_STATE" />
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" />
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_SYSTEM_EXEMPTED" />

<application
android:allowBackup="false"
Expand All @@ -13,7 +15,8 @@
<service
android:name=".VPNService"
android:permission="android.permission.BIND_VPN_SERVICE"
android:exported="false">
android:exported="false"
android:foregroundServiceType="systemExempted">
<intent-filter>
<action android:name="android.net.VpnService"/>
<action android:name="io.netbird.client.intent.action.START_SERVICE" />
Expand Down
Loading