Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meta/runtime.yml With Missing Modules #1356

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

newlandk
Copy link

Some modules like netbox_user_group cannot take advantage of module_defaults for arguments like netbox_url and netbox_token.

This appear to be due to the netbox action group not containing those modules. This PR is to add missing modules to the netbox action group.

Related Issue

Initial implementation of action group to support module_defaults.

#411

New Behavior

Modules defaults work with all current netbox ansible modules.

Contrast to Current Behavior

Module defaults like netbox_url and netbox_token do not get inherited by modules not listed in the netbox action_group. With the modules like netbox_user_group added, they now inherit the module_defaults.

Discussion: Benefits and Drawbacks

Consistent module_default parameter inheritance across all modules.

Proposed Release Note Entry

Added modules netbox_config_template, netbox_custom_field_choice_set, netbox_permission, netbox_token, netbox_user, and netbox_user_group to the netbox action group to support module_default parameter inheritance in those modules.

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

It appears some modules cannot take advantage of module_defaults, it appears to be due to them missing in the netbox action group.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant