#129 add community requested source and destination objects #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
rvveber
force-pushed
the
129_add_community_requested_source_and_destination_objects
branch
from
12dc111
to
7010069
Compare
|
Hi @rvveber - thanks for this, can I ask you take a look at https://netboxlabs.com/docs/netbox/en/stable/plugins/development/migration-v4/ - note the changes to serializers (hence this in conflict currently) |
Yes, i will look at it tomorrow! |
… only one Source Field can be specified
… only one Source Field can be specified
… only one Destination Field can be specified
…Tabbed Group; Improve Fieldsets
…urces; Add validation to restrict to a single Source
…Tabbed Group; Improve Fieldsets
…urces; Add validation to restrict to a single Source
…d as Tabbed Group
…stinations; Add validation to restrict to a single Destination
…ce column that will display any Source
…ce column that will display any Source
… Destination column that will display any Destination
…s Tabbed Group; Improve Fieldsets
…s Tabbed Group; Improve Fieldsets
…yed as Tabbed Group
…ple sources; Add validation to restrict to a single Source
…ple sources; Add validation to restrict to a single Source
…ple destinatiions; Add validation to restrict to a single Destination
rvveber
force-pushed
the
129_add_community_requested_source_and_destination_objects
branch
from
7010069
to
c0d5ab6
Compare
|
@cruse1977 i rebased onto the new version and updated my commits to solve the conflicts. |
|
@cruse1977 bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related Issue
closes #129
New Behavior
This Merge Request, enables to specify various new
SourceEntities for theStandardandExtendedACL Rules.It additionally enables to specify the same Entities as a
Destinationfor theExtendedACL Rule.The new selectable entities are all from the IPAM model group:
I have built in constraints and validation to prevent assigning more than one source/destination.
Therefore adding community requested entities, while keeping the functionality the same.
No changes to the API, except these newly added fields:
source_iprange,source_ipaddress,source_aggregate,source_serviceand
destination_iprange,destination_ipaddress,destination_aggregate,destination_service...
Contrast to Current Behavior
Previously you could only assign a Prefix as Source and Destination.
Now you can assign a Prefix, an IP-Range, an IP-Address, an Aggregate or a Service.
...
Discussion: Benefits and Drawbacks
...
Changes to the Documentation
...
Proposed Release Note Entry
Added requested models for selection as source/destination: IP-Range, IP-Address, Aggregate, Service.
...
Double Check
or in a linked issue.
devbranch.