update codefactor recommendations

netdevops · Jul 31, 2020 · aaa9154 · aaa9154
1 parent 19a7c5c
commit aaa9154
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 12 deletions.
diff --git a/netnir/core/tasks/inventory.py b/netnir/core/tasks/inventory.py
@@ -1,8 +1,5 @@
 from netnir.helpers.scaffold.command import CommandScaffold
 
-"""inventory cli commands
-"""
-
 
 class Inventory(CommandScaffold):
     """
@@ -13,9 +10,6 @@ def run(self):
         from netnir.plugins.facts import inventory_facts
         from nornir.plugins.functions.text import print_result
 
-        """
-        cli execution
-        """
         self.nr = self._inventory()
         results = self.nr.run(task=inventory_facts)
         print_result(results)

diff --git a/netnir/core/tasks/netconf.py b/netnir/core/tasks/netconf.py
@@ -1,10 +1,8 @@
 from netnir.helpers.scaffold.command import CommandScaffold
 
-"""netconf commands"""
-
 
 class NetConf(CommandScaffold):
-    """netconf commands class"""
+    """netconf commands"""
 
     def run(self):
         """execute netconf commands

diff --git a/netnir/helpers/scaffold/command.py b/netnir/helpers/scaffold/command.py
@@ -28,7 +28,7 @@ def parser(parser):
 
     def run(self):
         """things to do"""
-        pass
+        return "things to do"
 
     def _inventory(self):
         """filter inventory

diff --git a/netnir/plugins/netconf.py b/netnir/plugins/netconf.py
@@ -1,7 +1,5 @@
 from nornir.core.task import Task, Result
 
-"""netconf nornir plugin"""
-
 
 def netconf_get(task: Task) -> Result:
     """nornir netconf get task