netteForms.js: Set validation result CSS classes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. Best part is you've essentialy created hooks that can be overriden with custom functions. |
src/assets/netteForms.js
Outdated
| return true; | ||
| }; | ||
|
|
||
|
|
||
| Nette.markControlValid = function(elem) { | ||
| Nette.switchClass(elem, 'control-invalid', 'control-valid'); |
There was a problem hiding this comment.
Should have nette namespace.
dg
force-pushed
the
master
branch
2 times, most recently
from
131f7d2
to
532059a
Compare
|
This PR should be without any BC break. Adds CSS classes according to validation result of each control. Classes are prefixed with Functions can be overridden with custom ones ( So with this, on target system we can easily style valid/invalid form controls or add custom code executed for validation results. |
dg
force-pushed
the
master
branch
2 times, most recently
from
a57a557
to
55d0eb8
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
9e359e6
to
fa84d63
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
3c1619a
to
31bc0a3
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
6b04b51
to
d1c30d6
Compare
dg
force-pushed
the
master
branch
5 times, most recently
from
fd381fb
to
b70e5da
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
c996b4c
to
c8f4f95
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
49c38f3
to
c6f98c1
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
337f707
to
2146e59
Compare
dg
force-pushed
the
master
branch
6 times, most recently
from
94f43f0
to
fe374c5
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
cb844f0
to
1d8a434
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
479185b
to
8da5796
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it's useful visually distinguish valid/invalid inputs.
We use something like the code in this PR.
When we need to use another CSS classes or something absolutely different, it's possible redefine
Nette.markControlValidandNette.markControlInvalid.But I don't know if the PR should be accepted.
Also without it we can redefine
Nette.validateControl, call original backed-up function and handle the result.So most likely this will be closed without merge.
But I can try it and listen your opinions.