-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgraded to XCode 7.2 / Swift 2 #19
Open
ultrasaurus
wants to merge
53
commits into
nettlep:master
Choose a base branch
from
ultrasaurus:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a few comments with more info and links I found helpful
.toInt is no loger present in Swift 2 .None behaves differently than was documented the following compiles just fine: var foo = 4 if foo != .None { "something" } however, this does not compile: if foo != nil { "something" }
countElements is no longer available in Swift 2.0, use str.characters.count iterating thru characters in a string is now: for character in str.characters
enumerate(shoppingList) -> shoppingList.enumerate()
deleted a section on scoping, since it was referenced correctly later (line 79) println -> print when iterating over a string, use str.characters do { } while -> repeat { } while
'#' has been removed from Swift; double up to make the argument label the same as the parameter name to omit an external name for the second or subsequent parameters of a function, write an underscore (_) instead of an explicit external name for that parameter
also fixed some typos
before the text said the property was nil which it wasn’t, not sure how it was supposed to work so I made up a new example which illustrates the behavior
odd that Color and SurveyQuestion2 ever worked default initializer also appears to work differently adjusted comment and added example to illustrate how default values are initialized
adjusted comment to reflect that, since the bank’s coins print correctly at the end
@objc no longer required for testing protocol conformance with ‘is’ and ‘as’
plus added one simple example
&/ and &% removed in Swift 1.2
Hey Paul (@nettlep)! This is a great contribution by @ultrasaurus. I highly recommend pulling it into the master! Great repo! |
Yup! Awesome work @ultrasaurus ! @nettlep +1 merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #18