Unit tests for utilities and classes #5 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipperenzen
force-pushed
the
feature/5/unit-tests-for-utilities-and-classes
branch
from
0bc16bb to
1dc3329
Compare
mightymax
requested changes
Dec 6, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mightymax there are some issues with the
.run()tests forStage,Iterator, andGeneratorclasses. These tests worked before, but now seem to fail and not produce any data (no code was changed regarding the workings of these classes and they work as expected, but not in the unit test).Also noticed the
Stageclass'sthis.generatordoes not emit thethis.emit('generatorResult', quadCount)- I added a comment for this in the class, I did notice it would slow down my test a bit, also the expected results would change if this is emitted.#7 can be closed when a pipeline is started once this MR is reviewed and accepted.