fix: Race condition between iterator and generators #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddeboer
force-pushed
the
fix-race-condition
branch
from
9d6098e to
9b39b64
Compare
ddeboer
commented
May 26, 2024
| @@ -107,7 +107,7 @@ describe('Generator Class', () => { | |||
| await pipelineParallelGenerators.run() | |||
| const file = fs.readFileSync(filePath, {encoding: 'utf-8'}) | |||
| const fileLines = file.split('\n').sort() | |||
| expect(fileLines.length).to.equal(873) | |||
| expect(fileLines.length).to.equal(741) | |||
There was a problem hiding this comment.
This is lower because of the duplicate triples that were being generated.
There was a problem hiding this comment.
I can't seem to find where the duplicate triples issue is solved. Apparently you did (great!) but can you link me to the line(s)? I just want to make sure we do not introduce a OoM issue.
mightymax
approved these changes
May 27, 2024
|
🎉 This PR is included in version 1.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
ddeboer
commented
May 27, 2024
| } | ||
|
|
||
| private get batchSize(): number { | ||
| return this.stage.configuration.generator[this.index].batchSize ?? DEFAULT_BATCH_SIZE | ||
| } | ||
|
|
||
|
|
||
| public run($this?: NamedNode, batchSize?: number): void { | ||
| if ($this !== undefined) this.$thisList.push($this) |
There was a problem hiding this comment.
Here the URIs are added to the same this.$thisList property again, causing duplicates.over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(influenced by the
delayandbatchSizeconfig params) by ending theStage iff both Iterator and all Generators are ended.
and remove it from Generator.
Fix #45
Fix #53