Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: requirements for datasets violations #528

Merged
merged 21 commits into from
Dec 7, 2021

Conversation

lem-onade
Copy link
Collaborator

@lem-onade lem-onade commented Nov 30, 2021

Collections should now include all necessary attributes to pass validation.

Minimal example: https://datasetregister.netwerkdigitaalerfgoed.nl/validate.php?url=https%3A%2F%2Fpods.netwerkdigitaalerfgoed.nl%2Fstijntaelemans%2Fheritage-collections%2Fcatalog

For existing collections: saving them will add the missing attributes.

@lem-onade lem-onade marked this pull request as ready for review December 2, 2021 12:54
@johannadm johannadm self-requested a review December 7, 2021 08:51
@lem-onade lem-onade merged commit 5cac643 into develop Dec 7, 2021
@lem-onade lem-onade deleted the fix/comply-to-requirements-for-datasets branch December 7, 2021 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Catalog isn't valid Partial page when institution hasn't published its collections yet
2 participants