Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug fixes #558

Merged
merged 7 commits into from
Jan 19, 2022
Merged

fix: bug fixes #558

merged 7 commits into from
Jan 19, 2022

Conversation

lem-onade
Copy link
Collaborator

@lem-onade lem-onade commented Jan 14, 2022 •
edited
Loading

  • fix object edit page
  • fix login with NDE account after logout
  • fix create collection with NDE account
  • fix auth0 login on safari

@lem-onade lem-onade added the bug Something isn't working label Jan 14, 2022
@lem-onade lem-onade self-assigned this Jan 14, 2022
@lem-onade lem-onade linked an issue Jan 14, 2022 that may be closed by this pull request
Editing objects fails with call to localhost #555
Closed
@lem-onade lem-onade marked this pull request as draft January 14, 2022 10:44
@lem-onade lem-onade marked this pull request as ready for review January 17, 2022 15:29
@lem-onade lem-onade requested a review from johannadm January 17, 2022 15:29
@lem-onade
Copy link
Collaborator Author

@johannadm note that #554 is not fixed by this PR

johannadm
johannadm approved these changes Jan 18, 2022
View reviewed changes
Copy link
Collaborator

@johannadm johannadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well on chrome and firefox

@lem-onade lem-onade merged commit a1724ff into develop Jan 19, 2022
@lem-onade lem-onade deleted the fix/bug-fixes branch January 19, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannadm johannadm johannadm approved these changes

Assignees

@lem-onade lem-onade

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Editing objects fails with call to localhost
2 participants
@lem-onade @johannadm