Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update with scope of erfgoedpod #567

Open
wants to merge 3 commits into
base: feat/loan
Choose a base branch
from

Conversation

johannadm
Copy link
Collaborator

No description provided.

@johannadm johannadm requested a review from lem-onade January 27, 2022 08:11
Copy link
Collaborator

@lem-onade lem-onade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions and suggested rewordings

docs/modules/ROOT/pages/scope-EP.adoc Outdated Show resolved Hide resolved
== Functionaliteiten rond metadata
=== Aanvullen van metadata van een geleend object
Wanneer een ontvangende erfgoedinstelling een object in bruikleen heeft, kan de beheerder de oorspronkelijke waarden enkel lezen (read-only) maar kan hij er een annotatie bij plaatsen. De annotaties zullen dan worden opgeslagen in de Pod van de ontvangende erfgoedinstelling. Wanneer de annotaties zijn opgeslagen, wordt er een Linked Data Notification verstuurd naar de inbox van de uitgevende erfgoedinstelling 1. Zo krijgt erfgoedinstelling 1 de annotaties te zien die erfgoedinstelling 2 doorvoerde en kan erfgoedinstelling 1 deze updates verwerken indien gewenst.
In de UI van de ontvangende erfgoedinstelling zullen er form inputs te zien zijn waar correcties/annotaties kunnen worden ingevuld. Zo worden de oorspronkelijke metadata en de annotaties duidelijk van elkaar gescheiden. In de presentatiemodule van de ontvangende erfgoedinstelling wordt de annotatie getoond indien ingevuld. In het geval dat er geen annotatie werd ingevuld, wordt de oorspronkelijke waarde getoond.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In de presentatiemodule van de ontvangende erfgoedinstelling wordt de annotatie getoond indien ingevuld. In het geval dat er geen annotatie werd ingevuld, wordt de oorspronkelijke waarde getoond.

I think it will be easier to implement when the property fields can be edited like normal, without read-only inputs.
With extra input fields at the bottom, the user would have to first choose the property. After that, based on this choice, several types of inputs could be shown (regular text, numbers, dropdowns, term fields, ...)
I'm not sure it would be trivial to implement. It would also require some extra Figma work to be done.

In de presentatiemodule van de ontvangende erfgoedinstelling wordt de annotatie getoond indien ingevuld. In het geval dat er geen annotatie werd ingevuld, wordt de oorspronkelijke waarde getoond.

there is no visual distinction between the original values and the annotations in the presentation app right?

Indien erfgoedinstelling 2 (die het object leent), metadata heeft aangepast, krijgt erfgoedinstelling 1 een aanvraag voor de metadata update via een Linked Data Notification. Het verwerken van de metadata update gebeurt op de objectdetailpagina in een nieuw onderdeel ‘updates’. Op de objectdetailpagina bij erfgoedinstelling 1 (die het originele object bezit) wordt een link getoond naar de presentatiepagina van het object bij erfgoedinstelling 2. Erfgoedinstelling 1 krijgt de keuze om de metadata update goed of af te keuren die door erfgoedinstelling 2 wordt voorgesteld. Bij goedkeuring zullen de aanpassingen ook in de Pod van erfgoedinstelling 1 worden opgeslagen.

=== Extra informatie op objectdetailpagina bij bruikleen
In de beheer- en presentatiemodule wordt er per uitgeleend object/collectie informatie weergegeven met een link naar de originele instelling bij een uitgeleend object, of naar de uitlenende instelling bij een origineel object.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of naar de uitlenende instelling bij een origineel object.

I think 'uitlenende instelling' is confusing

docs/modules/ROOT/pages/userstories-EP.adoc Outdated Show resolved Hide resolved
As an admin of a heritage institution, I want to apply for certain collections/objects that I want to digitally lend from another heritage institution, so that I can display them in our own catalog even though we are not the owner .
As an admin of a heritage institution, I want to approve or dismiss the loan request from another heritage institution, so that I have control over the collections and objects of our institution that are lent.
As a user of Solid CRS, I want to copy the unique URL of an object or collection, so that I can refer to the exact object/collection when pasting the URL.
As an admin of a heritage institution, I want to have an overview of the requests that I sent out, so I don’t request the same objects/collections twice.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not listed in the functionalities, should this be added there?

As an admin of a heritage institution, I want to approve or dismiss the loan request from another heritage institution, so that I have control over the collections and objects of our institution that are lent.
As a user of Solid CRS, I want to copy the unique URL of an object or collection, so that I can refer to the exact object/collection when pasting the URL.
As an admin of a heritage institution, I want to have an overview of the requests that I sent out, so I don’t request the same objects/collections twice.
As an admin of a heritage institution, I want to be informed when my loan request gets approved, so I know when the requested loan items are added to our heritage page in Solid CRS.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the requested loan items will never be automatically added when the loan request was accepted. the requesting institution will receive an approval confirmation, after which they can choose to 'import' the requested collection into their own catalog.

the choosing part is optional, can be done automatically when retrieving the inbox entries after the institution logs in for instance. the point is that accepting the request does not trigger the transfer/copying of the requested collection.

As an admin of a heritage institution, I want to have an overview of the requests that I sent out, so I don’t request the same objects/collections twice.
As an admin of a heritage institution, I want to be informed when my loan request gets approved, so I know when the requested loan items are added to our heritage page in Solid CRS.
As an admin of a heritage institution, I want to be able to see the details of my requests, so I know which specific objects I requested and when I requested them.
As an admin of a heritage institution, I want to be able to add a comment to my loan request, so the approving institution can understand the reason why we request these items.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure providing a single text input deserves its own user story. I think it belongs under the first one:

As an admin of a heritage institution, I want to apply for certain collections/objects that I want to digitally lend from another heritage institution, so that I can display them in our own catalog even though we are not the owner .

docs/modules/ROOT/pages/userstories-EP.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/userstories-EP.adoc Outdated Show resolved Hide resolved
docs/modules/ROOT/pages/userstories-EP.adoc Outdated Show resolved Hide resolved
@lem-onade lem-onade self-requested a review February 14, 2022 14:25
@lem-onade lem-onade removed their request for review July 25, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants