Adds utility functions for ios parser #139

mundruid · 2022-08-02T20:50:37Z

Adds:

get_path
get_path_with_children

Addresses partially issue: #124

Remove unused link.

Move to constants, fix doctest, make dns actions more clear, clean up wording to be more clear

Updates for 0.2.0 release

update changelog

Release 0.2.0

* Add ASA parser Co-authored-by: Justin Drew <[email protected]>

* Add BASE_INTERFACES for hp_comware & checkpoint Co-authored-by: Josef Fuchs <[email protected]>

prep for 0.2.1 release

release 0.2.1

Adds docs for readthedocs

Updated attribution and contribution doc start-lines

move sphinx to dev dep, update docs, update metadata

* Small performance enhancers - remove redundant call to `str` - `get_all_host` list to generator to avoid memory overhead of very large lists * Add lookup table for netmasks There are only 32 + 128 valid IPv4/6 netmasks, so I created a lookup table for easy validation. If there are concerns about the memory overhead, a computed version is easy enough to implement. * Make netutils dual-stack I modified functions where I could to make them compatible with IPv6. Per [RFC4291](https://datatracker.ietf.org/doc/html/rfc4291#section-4), I have assumed any addresses in the ::/8 range are IPv4. The one exception is `cidr_to_netmask`. I added a v6 version of that function. * Modify/add tests for proposed functionality

* remove count_bits tests * Remove count_bits in favor of simpler/faster function

* interface_range_expansion function added

Co-authored-by: Adam Byczkowski <[email protected]>

Add interface sorting support.

1.1.0 release

* Updated lib mapping docs * Updated per review suggestions

Switch to poetry-core

Update banner parsing for EOS

* fixes encrypt type7

* initial pass at type hinting and getting mypy to run * update tasks and ci to do mypy as well * rm unused import * fix contributing end-line number * fix contributing end-line number * Add py.typed file to signify availability of type hints to third parties. * Updates to type hinting. * Add EOS _build_banner type hints. * Address feedback. * Linting. * Remove .idea from commit and ignore in .gitignore. * Remove remnants of merge conflict. * PR feedback. * PR comments. * Ignore pylint errors for abstract-method. * Black. * add examples and better exception messaging Co-authored-by: Leo Kirchner <[email protected]>

itdependsnetworks · 2022-08-02T21:11:11Z

Nice!! Two thoughts

Can you move to BaseSpaceConfigParser, this "should" be the same for all configs that inherit from BaseSpaceConfigParser
Does it make sense to use the language that CiscoConfParse uses? This would be helpful for training/documentation, which seems to define:

find_all_children
find_blocks
find_children
find_children_w_parents
find_interface_objects
find_lineage
find_lines
find_object_branches
find_objects
find_objects_dna
find_objects_w_all_children
find_objects_w_child
find_objects_w_missing_children
find_objects_w_parents
find_objects_wo_child
find_parents_w_child
find_parents_wo_child

We could use "get" instead of find potentially, worth a convo at a min.

itdependsnetworks · 2022-08-03T03:23:31Z

netutils/config/parser.py

+          neighbor 192.168.1.2 activate
+          network 172.17.1.0 mas
+        """
+        children = []


I think method could be solved with [a.config_line for a in config_tree.build_config_relationship() if a.parents and a.parents[0] == pattern]

What you are suggesting does not return anything, it returns an empty list.

itdependsnetworks · 2022-08-03T03:26:42Z

netutils/config/parser.py

+          neighbor 192.168.1.2 activate
+          network 172.17.1.0 mas
+        """
+        parents_and_children = []


I think this method can be handled with [a.config_line for a in config_tree.build_config_relationship() if a.parents and a.parents[0] == pattern or a.config_line == pattern]

What you are suggesting does not return anything, it returns an empty list.

itdependsnetworks · 2022-08-03T03:30:52Z

tests/unit/test_docs.py

@@ -72,7 +72,7 @@ def test_sphinx_build(data):
    sphinx_dummy_build = subprocess.run(  # pylint: disable=W1510
        ["sphinx-build", "-b", "dummy", "-W", data["source_dir"], data["build_dir"]], stdout=subprocess.PIPE
    )
-    assert sphinx_dummy_build.returncode == 0
+    assert sphinx_dummy_build.returncode == 2


I am not sure why docs are failing, but shouldn't expect a non-zero return code (unless testing for specific failure)

Changed based on the suggestion, the test works now.

qduk · 2022-08-03T13:49:20Z

netutils/config/parser.py

+        Example:
+        root_obj.get_path("router bgp 45000")
+        # Returns
+         address-family ipv4 unicast
+          neighbor 192.168.1.2 activate
+          network 172.17.1.0 mas


Suggested change

Example:

root_obj.get_path("router bgp 45000")

# Returns

address-family ipv4 unicast

neighbor 192.168.1.2 activate

network 172.17.1.0 mas

Example:

>>> config = '''

... router bgp 45000

... address-family ipv4 unicast

... neighbor 192.168.1.2 activate

... network 172.17.1.0 mas'''

>>> bgp_conf = IOSConfigParser.get_path(config)

>>> print(bgp_conf)

address-family ipv4 unicast

neighbor 192.168.1.2 activate

network 172.17.1.0 mas

Sphinx doesn't like the indentation in the docstring here and the function below. The suggestion should be good though.

Changed based on the suggestion, the test works now.

jeffkala · 2022-08-03T13:10:02Z

netutils/config/parser.py

+        """Returns configuration part for specific pattern not including parents.
+
+        Args:
+            pattern (str): pattern that describes for parent.


Now that this full library is type hinted we no longer need to provide the "types" within the docstrings.

Suggested change

pattern (str): pattern that describes for parent.

pattern: pattern that describes for parent.

jeffkala · 2022-08-03T13:10:22Z

netutils/config/parser.py

+            pattern (str): pattern that describes for parent.
+
+        Returns:
+            list: configuration under that parent pattern.


Suggested change

list: configuration under that parent pattern.

configuration under that parent pattern.

jeffkala · 2022-08-03T13:10:48Z

netutils/config/parser.py

+        """Returns configuration part for specific pattern including parents and children.
+
+        Args:
+            pattern (str): pattern that describes for parent.


Suggested change

pattern (str): pattern that describes for parent.

pattern: pattern that describes for parent.

jeffkala · 2022-08-03T13:11:00Z

netutils/config/parser.py

+            pattern (str): pattern that describes for parent.
+
+        Returns:
+            list: configuration under that parent pattern.


Suggested change

list: configuration under that parent pattern.

configuration under that parent pattern.

jeffkala · 2022-08-03T13:26:25Z

netutils/config/parser.py

+        return grouped_data
+
+    def get_path(self, pattern: str) -> t.List[str]:
+        """Returns configuration part for specific pattern not including parents.


Suggested change

"""Returns configuration part for specific pattern not including parents.

"""Returns child configurations for a specific pattern not including parents.

jeffkala · 2022-08-03T13:27:24Z

netutils/config/parser.py

+        return children
+
+    def get_path_with_parents(self, pattern: str) -> t.List[str]:
+        """Returns configuration part for specific pattern including parents and children.


Suggested change

"""Returns configuration part for specific pattern including parents and children.

"""Returns configuration section for a specific pattern including parents and children.

jeffkala · 2022-08-03T19:42:18Z

Something seemed to happen with this PR, showing 182 filles changed.

mundruid · 2022-08-03T19:56:50Z

Overlaps with #140

ubajze and others added 30 commits May 12, 2021 15:57

Update travis configuration to release a new version from CI/CD pipeline

540833d

Remove unused link.

dbaa471

Merge pull request #7 from networktocode/itdependsnetworks-patch-1

54d790c

Remove unused link.

Updates for 0.2.0 release

46937ec

Move to constants, fix doctest, make dns actions more clear, clean up wording to be more clear

Merge pull request #12 from networktocode/release0.2.0

fb9747a

Updates for 0.2.0 release

update changelog

93f6ce9

Merge pull request #13 from networktocode/changelog

9b02398

update changelog

Merge pull request #14 from networktocode/develop

88be83b

Release 0.2.0

Add ASA Parser (#16)

81aed6c

* Add ASA parser Co-authored-by: Justin Drew <[email protected]>

Add BASE_INTERFACES for hp_comware & checkpoint (#17)

b0c607c

* Add BASE_INTERFACES for hp_comware & checkpoint Co-authored-by: Josef Fuchs <[email protected]>

prep for 0.2.1 release

9b2bd58

Merge pull request #19 from networktocode/0.2.1

9615e28

prep for 0.2.1 release

Merge pull request #20 from networktocode/develop

0643e59

release 0.2.1

Created docs

7b96016

Merge pull request #8 from qduk/feature/docs

1f21336

Adds docs for readthedocs

Updated docs start line

41f6413

Merge pull request #24 from qduk/hotfix/Updates_attribution_docs

12ba382

Updated attribution and contribution doc start-lines

move sphinx to dev dep, update docs, update metadata

d77d718

add pytest ids

d793a93

Merge pull request #25 from networktocode/docsandmore

de0bb30

move sphinx to dev dep, update docs, update metadata

Remove unnecessary code from ip (#30)

1abd921

* remove count_bits tests * Remove count_bits in favor of simpler/faster function

interface_range_expansion function added (#31)

aa1e5d7

* interface_range_expansion function added

Add interface sorting support.

ee71ce3

Update netutils/interface.py

d3fb099

Co-authored-by: Adam Byczkowski <[email protected]>

Update netutils/interface.py

724c38f

Co-authored-by: Adam Byczkowski <[email protected]>

Cleanup docs from PR suggestions.

c8917c5

Rename split_interface_tuple to private member

e001fa3

Merge pull request #34 from dgjustice/dgjustice

ce4e497

Add interface sorting support.

Remove the requests package

244432d

jeffkala and others added 9 commits April 23, 2022 11:41

Merge pull request #110 from networktocode/develop

962b32d

1.1.0 release

Updated lib mapping docs (#113)

40a120c

* Updated lib mapping docs * Updated per review suggestions

Pinned mistune for m2r2 (#114)

6c9b161

Switch to poetry-core

ba0a527

Merge pull request #115 from fabaff/patch-1

617a2a7

Switch to poetry-core

Update banner parsing for EOS (#121)

d5cd599

Update banner parsing for EOS

Fixes encrypt type7 (#122)

aab97df

* fixes encrypt type7

Document support on duplicate lines (#128)

acb2716

mundruid requested review from itdependsnetworks, jeffkala and qduk as code owners August 2, 2022 20:50

Xenia Mountrouidou added 6 commits August 2, 2022 17:30

fixes conflicts

620813c

adds tests

8ba5f27

remove double import

1665a10

rebasing

c2460f0

fixes mypy

bfeec06

fixes test

dbcedd1

itdependsnetworks reviewed Aug 3, 2022

View reviewed changes

qduk reviewed Aug 3, 2022

View reviewed changes

jeffkala requested changes Aug 3, 2022

View reviewed changes

Xenia Mountrouidou added 2 commits August 3, 2022 13:04

remove parts config

4906e4f

removes old config

80a2e59

mundruid closed this Aug 3, 2022

mundruid deleted the x/get_certificate branch August 4, 2022 12:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds utility functions for ios parser #139

Adds utility functions for ios parser #139

mundruid commented Aug 2, 2022 •

edited

Loading

itdependsnetworks commented Aug 2, 2022

itdependsnetworks Aug 3, 2022

mundruid Aug 3, 2022

itdependsnetworks Aug 3, 2022

mundruid Aug 3, 2022

itdependsnetworks Aug 3, 2022

mundruid Aug 3, 2022

qduk Aug 3, 2022

mundruid Aug 3, 2022

jeffkala Aug 3, 2022

mundruid Aug 3, 2022

jeffkala Aug 3, 2022

mundruid Aug 3, 2022

jeffkala Aug 3, 2022

mundruid Aug 3, 2022

jeffkala Aug 3, 2022

mundruid Aug 3, 2022

jeffkala Aug 3, 2022

mundruid Aug 3, 2022

jeffkala Aug 3, 2022

mundruid Aug 3, 2022

jeffkala commented Aug 3, 2022

mundruid commented Aug 3, 2022

	pattern (str): pattern that describes for parent.
	pattern: pattern that describes for parent.

	list: configuration under that parent pattern.
	configuration under that parent pattern.

	"""Returns configuration part for specific pattern not including parents.
	"""Returns child configurations for a specific pattern not including parents.

	"""Returns configuration part for specific pattern including parents and children.
	"""Returns configuration section for a specific pattern including parents and children.

Adds utility functions for ios parser #139

Adds utility functions for ios parser #139

Conversation

mundruid commented Aug 2, 2022 • edited Loading

itdependsnetworks commented Aug 2, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jeffkala commented Aug 3, 2022

mundruid commented Aug 3, 2022

mundruid commented Aug 2, 2022 •

edited

Loading