-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encrypt_type9
function to netutils.password
#216
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest option '--no-cov' causes pytest to crash if pytest-cov plugin not installed
cisco type 9 passwords use the scrypt key derivation function, as implemented in the cryptography package
alextremblay
requested review from
itdependsnetworks,
jeffkala,
qduk and
abates
as code owners
February 16, 2023 18:55
salt generator using base85 may produce salt which includes '$'. The `get_hash_salt` function will not be able to reliably extract the salt from any hash produced using this generator switches to a `secrets`-based salt generator
abates
reviewed
Feb 16, 2023
abates
reviewed
Feb 16, 2023
remove dependence on `cryptography` package
update test suite with input/output derived from real switch config
alextremblay
force-pushed
the
develop
branch
from
February 16, 2023 22:01
2ac4f03
to
7688253
Compare
alextremblay
requested review from
abates and
itdependsnetworks
and removed request for
itdependsnetworks,
qduk,
jeffkala and
abates
February 16, 2023 23:01
Closing in favor of #253. @alextremblay I've updated your originally submitted code and opened a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #96