Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encrypt_type9 function to netutils.password #216

Closed
wants to merge 17 commits into from

Conversation

alextremblay
Copy link
Contributor

Related to #96

pytest option '--no-cov' causes pytest to crash if pytest-cov plugin not installed
cisco type 9 passwords use the scrypt key derivation function, as implemented in the cryptography package
salt generator using base85 may produce salt which includes '$'.

The `get_hash_salt` function will not be able to reliably extract the salt from any hash produced using this generator

switches to a `secrets`-based salt generator
netutils/password.py Outdated Show resolved Hide resolved
netutils/password.py Outdated Show resolved Hide resolved
@abates
Copy link
Contributor

abates commented Mar 30, 2023

Closing in favor of #253.
We tend to shy away from optional/external dependencies. The built-in scrypt functionality should be available out of the box on most systems and with minimal work on MacOS.

@alextremblay I've updated your originally submitted code and opened a new PR.

@abates abates closed this Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants