Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cisco_ios_show_platform, only for switches #1892

Merged
merged 15 commits into from
Dec 2, 2024
Merged

cisco_ios_show_platform, only for switches #1892

merged 15 commits into from
Dec 2, 2024

Conversation

Uncle-Dee
Copy link
Contributor

Only for switches.

jmcgill298
jmcgill298 requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @Uncle-Dee , we will also need test cases to be added to ensure ongoing compatibility. https://ntc-templates.readthedocs.io/en/latest/dev/dev_parser/#tests

ntc_templates/templates/cisco_ios_show_platform.textfsm Outdated Show resolved Hide resolved
ntc_templates/templates/index Outdated Show resolved Hide resolved
jmcgill298
jmcgill298 requested changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@jmcgill298 jmcgill298 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes for standardization, should be able to commit this suggestions and be good to go.

ntc_templates/templates/cisco_ios_show_platform.textfsm Outdated Show resolved Hide resolved
ntc_templates/templates/cisco_ios_show_platform.textfsm Outdated Show resolved Hide resolved
tests/cisco_ios/show_platform/cisco_ios_show_platform.raw Outdated Show resolved Hide resolved
tests/cisco_ios/show_platform/cisco_ios_show_platform.yaml Outdated Show resolved Hide resolved
ntc_templates/templates/cisco_ios_show_platform.textfsm Outdated Show resolved Hide resolved
tests/cisco_ios/show_platform/cisco_ios_show_platform.yaml Outdated Show resolved Hide resolved
tests/cisco_ios/show_platform/cisco_ios_show_platform.yaml Outdated Show resolved Hide resolved
Uncle-Dee and others added 8 commits December 2, 2024 16:46
@Uncle-Dee @jmcgill298
Update ntc_templates/templates/cisco_ios_show_platform.textfsm
5c41291 
Co-authored-by: Jacob McGill <[email protected]>
@Uncle-Dee @jmcgill298
Update tests/cisco_ios/show_platform/cisco_ios_show_platform.raw
ac3d872 
Co-authored-by: Jacob McGill <[email protected]>
@Uncle-Dee @jmcgill298
Update ntc_templates/templates/cisco_ios_show_platform.textfsm
524347a 
Co-authored-by: Jacob McGill <[email protected]>
@Uncle-Dee @jmcgill298
Update ntc_templates/templates/cisco_ios_show_platform.textfsm
f76d97e 
Co-authored-by: Jacob McGill <[email protected]>
@Uncle-Dee @jmcgill298
Update tests/cisco_ios/show_platform/cisco_ios_show_platform.yaml
bb66986 
Co-authored-by: Jacob McGill <[email protected]>
@Uncle-Dee @jmcgill298
Update tests/cisco_ios/show_platform/cisco_ios_show_platform.yaml
dd18457 
Co-authored-by: Jacob McGill <[email protected]>
@Uncle-Dee @jmcgill298
Update tests/cisco_ios/show_platform/cisco_ios_show_platform.yaml
524d70b 
Co-authored-by: Jacob McGill <[email protected]>
@Uncle-Dee @mjbear
Update ntc_templates/templates/cisco_ios_show_platform.textfsm
61657f4 
Co-authored-by: Michael Bear <[email protected]>
@Uncle-Dee
Copy link
Contributor Author

@mjbear @jmcgill298 I am very grateful for your comments and assistance.

@jmcgill298 jmcgill298 merged commit d477229 into networktocode:master Dec 2, 2024
14 checks passed
@Uncle-Dee Uncle-Dee deleted the cisco_ios_show_platform branch December 2, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjbear mjbear mjbear left review comments

@jmcgill298 jmcgill298 jmcgill298 approved these changes

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uncle-Dee @jmcgill298 @mjbear