feat: Add show service id sap #1914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bennnnnnnn
requested review from
itdependsnetworks,
jmcgill298 and
jvanderaa
as code owners
mjbear
reviewed
Nov 26, 2024
ntc_templates/templates/alcatel_sros_show_service_id_0_sap.textfsm
Outdated
Show resolved
Hide resolved
|
@bennnnnnnn Edit: Meant this for the main thread. |
…p.textfsm Take into account @mjbear's suggestions Co-authored-by: Michael Bear <[email protected]>
|
@mjbear thanks for the reviews and suggestions! Helps me to get some insights into how most of these templates are composed. We're adopting this great package in our team and I'm trying to upstream our contributions 👍 |
jmcgill298
reviewed
Nov 27, 2024
ntc_templates/templates/alcatel_sros_show_service_id_0_sap.textfsm
Outdated
Show resolved
Hide resolved
jmcgill298
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add show service id -x- sap command for Alcatel SROS