Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend cisco_ios set_boot_options method #311

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Extend cisco_ios set_boot_options method #311

merged 4 commits into from
Sep 13, 2024

Conversation

pszulczewski
Copy link
Contributor

No description provided.

@pszulczewski pszulczewski linked an issue Feb 22, 2024 that may be closed by this pull request
3750 IOS Boot Options don't meet the current code checks #286
Closed
@jvanderaa
Copy link
Contributor

@pszulczewski thoughts on this?

@pszulczewski
Copy link
Contributor Author

pszulczewski commented Aug 29, 2024 •
edited
Loading

@jvanderaa yes, there was a test to fix therefore this PR was in Draft ... and has been forgotten :).
Now the test is fixed and I went one step further to refresh poetry lock, which reveled some linting issues.
Whoever is going to review, bear in mind that the first commit is to fix the issue. Second commit is fixing the unit test, the rest is linting, caused by poetry.lock update.

@pszulczewski pszulczewski marked this pull request as ready for review August 29, 2024 10:34
@jeffkala jeffkala merged commit 6cd4e38 into develop Sep 13, 2024
12 checks passed
@jeffkala jeffkala deleted the fix_no_boot_options branch September 13, 2024 20:39
@jeffkala jeffkala restored the fix_no_boot_options branch December 6, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanderaa jvanderaa jvanderaa approved these changes

@jmcgill298 jmcgill298 jmcgill298 approved these changes

@jeffkala jeffkala Awaiting requested review from jeffkala jeffkala is a code owner

@pke11y pke11y Awaiting requested review from pke11y pke11y is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3750 IOS Boot Options don't meet the current code checks
4 participants
@pszulczewski @jvanderaa @jmcgill298 @jeffkala