Support Pydantic Models for Validation #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ories. Will work on implementing pulling from other Python packages.
…to consume models.
FragmentedPacket
requested review from
chadell and
glennmatthews
as code owners
chadell
reviewed
Mar 4, 2024
Co-authored-by: Christian Adell <[email protected]>
chadell
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
The suggestion looks reasonable to me. I would defer to @glennmatthews to add his review.
glennmatthews
approved these changes
Mar 6, 2024
| @@ -97,7 +97,24 @@ def top_level_properties(self): | |||
| """ | |||
| if not self._top_level_properties: | |||
| content = self._get_content() | |||
| self._top_level_properties = set(content.keys()) | |||
| # TODO: Investigate and see if we should be checking this on initialization if the file doesn't exists or is empty. | |||
| if not content: | |||
There was a problem hiding this comment.
Should this be something like if content is None? Or is it intentional that if content is an empty dict, empty str, or empty list then _top_level_properties is unchanged?
There was a problem hiding this comment.
It is intentional. We can exit early if there is not content aka no data in the variable it found.
I was thinking we should handle this in the find_files function. If the variable file is empty, no reason to worry about the file any longer (it won't have top level properties since it doesn't have content).
tests/fixtures/test_validators_pydantic/inventory/host_vars/az_phx_pe01/dns.yml
Show resolved
Hide resolved
tests/fixtures/test_validators_pydantic/inventory/host_vars/co_den_p01/dns.yml
Show resolved
Hide resolved
tests/fixtures/test_validators_pydantic/pydantic_validators/models/interfaces.py
Outdated
Show resolved
Hide resolved
…dPacket/schema-enforcer into feat/pydantic-model-validation
…en encountering invalid package/module when loading Pydantic models from an external package. Minor changes to address feedback.
glennmatthews
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PydanticManagerfor loading Pydantic models from libraries.PydanticValidationto run the specific Pydantic model validation against data.validator_directoryas well.[ERROR]line.