Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nobrainer.dataset.Dataset wraps tf.data.Dataset and provides standard functionality #254

Closed
ohinds opened this issue Aug 4, 2023 · 1 comment
Closed

nobrainer.dataset.Dataset wraps tf.data.Dataset and provides standard functionality #254

ohinds opened this issue Aug 4, 2023 · 1 comment
Labels
enhancement feature request minor

Comments

@ohinds
Copy link
Contributor

ohinds commented Aug 4, 2023

Currently, the various methods of nobrainer.dataset.Dataset for loading data return a raw tf.data.Dataset, even though the nobrainer.processing API expects nobrainer-specific members (e.g., volume_shape) when training. Instead, users should work with a nobrainer.dataset.Dataset directly, which could extend or maintain an internal tf.data.Dataset.

This would solve #244, and be consistent with the paradigm of the nobrainer.processing.base.BaseEstimator's treatment of the model.
@ohinds ohinds mentioned this issue Aug 30, 2023
Merged
6 tasks
@ohinds
Copy link
Contributor Author

ohinds commented Aug 31, 2023

Fixed by #261

@ohinds ohinds closed this as completed Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement feature request minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ohinds