nobrainer dataset API rework
#261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ohinds-nb-dataset
for more information, see https://pre-commit.ci
|
Note that there is a parallel PR in the |
satra
reviewed
Aug 31, 2023
…ainer into ohinds-nb-dataset
for more information, see https://pre-commit.ci
…ainer into ohinds-nb-dataset
|
@ohinds - this created a major release. i should have checked the existing labels before tagging a release. i was hoping to avoid major till we settled on api. |
|
shoot yeah. i didn’t realize that the labels worked in concert like that. i
was just trying to indicate that it was a major changeset. can we undo that?
…On Fri, Sep 1, 2023 at 7:12 PM Satrajit Ghosh ***@***.***> wrote:
@ohinds <https://github.com/ohinds> - this created a major release. i
should have checked the existing labels before tagging a release. i was
hoping to avoid major till we settled on api.
—
Reply to this email directly, view it on GitHub
<#261 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAEVNHYP4Q7C5E5GZUFPAT3XYKIZ3ANCNFSM6AAAAAA4FDOTJQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
undo requires a set of steps but we will never be able to release a 1.0.0 since pypi doesn't allow replacing a version that has been released. let's just go with what has happened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Summary
Major rework of the
nobrainerdataset API. This provides much more flexibility in creating and manipulating datasets, e.g. for augmentation, shuffling, repeating, and arbitrary mapping.Fixes #244 and #254.
Checklist
Acknowledgment