ExternalProject SUNDIALS 3.2.1 #1960
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| # ============================================================================= | ||
| # Sundials | ||
| # ============================================================================= | ||
|
|
||
| include(ExternalProject) | ||
| set(SUNDIALS_PREFIX "${THIRD_PARTY_DIRECTORY}/sundials") | ||
| set(SUNDIALS_INCLUDE_DIR "${SUNDIALS_PREFIX}/include") | ||
| set(SUNDIALS_LIB_DIR "${SUNDIALS_PREFIX}/lib") | ||
| make_directory(${SUNDIALS_INCLUDE_DIR}) | ||
|
|
||
| set(SUNDIALS_C_FLAGS ${CMAKE_C_FLAGS}) | ||
| list(REMOVE_ITEM SUNDIALS_C_FLAGS "-tp=haswell") | ||
| set(SUNDIALS_CXX_FLAGS ${CMAKE_CXX_FLAGS}) | ||
| list(REMOVE_ITEM SUNDIALS_CXX_FLAGS "-tp=haswell") | ||
| include(ExternalProject) | ||
| ExternalProject_Add( | ||
| sundials-external | ||
| PREFIX "${SUNDIALS_PREFIX}" | ||
| # cmake-format: off | ||
| # GIT_REPOSITORY https://github.com/LLNL/sundials.git | ||
| # Forked to following, to allow RPowerR to use hoc_pow | ||
| GIT_REPOSITORY https://github.com/neuronsimulator/sundials.git | ||
| # GIT_TAG e2f29c34f324829302037a1492db480be8828084 6.2.0 -> CVodeMem no longer "visible" GIT_TAG | ||
| # c09e732080a214694b209032ec627c93fed45340 4 | ||
| #GIT_TAG 811234254d37652954daff0ccdb7af9813736846 # 3.2.1 | ||
| GIT_TAG 71b3daec18ce66a7c011be9501a31567aa5c09b6 # 3.2.1 hines/hoc_pow | ||
| # GIT_TAG 7ed895fd102226dbc52225e6b2c6e26ef1cafa0e #2.7.0 | ||
| # cmake-format: on | ||
| GIT_SHALLOW ON | ||
| GIT_PROGRESS ON | ||
| # UPDATE_COMMAND "" | ||
| CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=<INSTALL_DIR> | ||
| -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER} | ||
| -DCMAKE_CXX_COMPILER=${CMAKE_CXX_COMPILER} | ||
| -DCMAKE_C_FLAGS=${SUNDIALS_C_FLAGS} | ||
| -DCMAKE_CXX_FLAGS=${SUNDIALS_CXX_FLAGS} | ||
| -DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE} | ||
| -DEXAMPLES_INSTALL=OFF | ||
| -DBUILD_ARKODE=OFF | ||
| -DBUILD_CVODES=OFF | ||
| -DBUILD_IDAS=OFF | ||
| -DBUILD_KINSOL=OFF | ||
| -DEXAMPLES_ENABLE_C=OFF | ||
| -DMPI_ENABLE=OFF | ||
| -DPTHREAD_ENABLE=ON | ||
| -DSUNDIALS_PRECISION=double | ||
| -DUSE_GENERIC_MATH=ON | ||
| -DCMAKE_POSITION_INDEPENDENT_CODE=ON | ||
| -DBUILD_SHARED_LIBS=OFF | ||
| -DMPI_C_COMPILER=${MPI_C_COMPILER} | ||
| -DCMAKE_INSTALL_LIBDIR=${SUNDIALS_LIB_DIR} | ||
| BUILD_BYPRODUCTS | ||
|
There was a problem hiding this comment. FYI: this is needed for Ninja |
||
| <INSTALL_DIR>/lib/libsundials_ida.a <INSTALL_DIR>/lib/libsundials_cvode.a | ||
| <INSTALL_DIR>/lib/libsundials_nvecserial.a <INSTALL_DIR>/lib/libsundials_nvecpthreads.a | ||
| <INSTALL_DIR>/lib/libsundials_nvecparallel.a) | ||
|
There was a problem hiding this comment. There was a problem hiding this comment. My experience with There was a problem hiding this comment. I'm all in for ExternalProject_Add 🚀 given that we can do custom build/configure commands, it will be definitely useful for upgrading to newer sundials. |
||
|
|
||
| add_library(SUNDIALS INTERFACE IMPORTED) | ||
| add_dependencies(SUNDIALS sundials-external) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nrnhines : is this LLNL/sundials@main...neuronsimulator:sundials:hines/hoc_pow only change that we need to have? Indeed it's look very trivial.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct for Sundials version 3. We'll eventually see if changes need to be more substantial for later versions. There is some question about where to put the 10 nrn/src/nrniv/nvector_* files. They distinguish between (serial, thread, mpi) and (double, longdouble) and I don't think the changes are relevant to sundials as they have details that depend on how NEURON uses threads and mpi and NRN_ENABLE_MPI_DYNAMIC. At the moment, when
NRN_ENABLE_MPI_DYNAMIC=ON, then
nm libnrniv.so | grep MPIshows nothing that points into libmpi. Instead, many things point into mpi specific interface libraries such as libnrnmpi_mpich.so and libnrnmpi_ompi.so . I think the worst case, ultimately, is that sundials gets built for each ```-DNRN_MPI_DYNAMIC="mpi;versions" and then all of sundials gets linked into each of the various libnrnmpi_.so