Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Update rxd currents when the model structure is changed. #2320

Merged
merged 7 commits into from
Aug 15, 2023

Conversation

adamjhn
Copy link
Member

@adamjhn adamjhn commented Apr 10, 2023

No description provided.

@adamjhn adamjhn added the rxd reaction-diffusion label Apr 10, 2023
@adamjhn adamjhn requested a review from ramcdougal April 10, 2023 20:42
@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #2320 (e8c7915) into master (8616d59) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2320      +/-   ##
==========================================
+ Coverage   60.36%   60.39%   +0.02%     
==========================================
  Files         626      626              
  Lines      120832   120835       +3     
==========================================
+ Hits        72945    72980      +35     
+ Misses      47887    47855      -32     
Files Changed Coverage Δ
share/lib/python/neuron/rxd/initializer.py 89.28% <100.00%> (+0.60%) ⬆️
share/lib/python/neuron/rxd/rxd.py 83.99% <100.00%> (+0.01%) ⬆️
src/nrnpython/rxd.cpp 89.52% <100.00%> (-0.02%) ⬇️

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bbpbuildbot

This comment has been minimized.

@ramcdougal ramcdougal added this to the Release 9.0 Alpha milestone May 21, 2023
@azure-pipelines
Copy link

✔️ 886c0b7 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link
Member

@ramcdougal ramcdougal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@azure-pipelines
Copy link

✔️ bbb5235 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@azure-pipelines
Copy link

✔️ e8c7915 -> Azure artifacts URL

@ramcdougal ramcdougal merged commit 1e8e707 into master Aug 15, 2023
33 checks passed
@ramcdougal ramcdougal deleted the fix_rxd_currents branch August 15, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rxd reaction-diffusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants