Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leak in write_nrnthread. #2456

Merged
merged 3 commits into from
Aug 21, 2023

remove unused methods

932cd32
Select commit
Loading
Failed to load commit list.
Merged

Fix leak in write_nrnthread. #2456

remove unused methods
932cd32
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Aug 21, 2023 in 0s

60.42% (+0.00%) compared to efc28fe

View this Pull Request on Codecov

60.42% (+0.00%) compared to efc28fe

Details

Codecov Report

Merging #2456 (932cd32) into master (efc28fe) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2456   +/-   ##
=======================================
  Coverage   60.41%   60.42%           
=======================================
  Files         626      626           
  Lines      120812   120799   -13     
=======================================
+ Hits        72990    72992    +2     
+ Misses      47822    47807   -15     
Files Changed Coverage Δ
...rniv/nrncore_write/callbacks/nrncore_callbacks.cpp 93.38% <ø> (ø)
src/nrniv/nrncore_write/io/nrncore_io.h 100.00% <ø> (ø)
src/nrniv/nrncore_write/io/nrncore_io.cpp 76.76% <100.00%> (+3.35%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more