Modernize graph.cpp to use data_handles. #2463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit modernizes the use of `pd + i` in `Graph::choose_sym()`.
|
To check during review:
|
|
✔️ d97001a -> Azure artifacts URL |
Codecov Report
@@ Coverage Diff @@
## master #2463 +/- ##
=======================================
Coverage 60.41% 60.41%
=======================================
Files 626 626
Lines 120816 120813 -3
=======================================
- Hits 72990 72989 -1
+ Misses 47826 47824 -2
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This comment has been minimized.
This comment has been minimized.
nrnhines
approved these changes
Aug 16, 2023
There was a problem hiding this comment.
Tested manually. Certainly fixes the issue. There are a number of surprising behaviors with the [all] syntax for Plot what? selection persistence in regard to saving/restoring sessions and changing nseg. However these problems existed from the beginning and have nothing to do with data handles. So this PR should be merged as is.
|
✔️ 094bd39 -> Azure artifacts URL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit modernizes the use of
pd + iinGraph::choose_sym().