Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify solving of sparse matrix #2639

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Simplify solving of sparse matrix #2639

merged 1 commit into from
Dec 12, 2023

Conversation

alkino
Copy link
Member

@alkino alkino commented Dec 12, 2023

If we give a matrix to the SparseLU ctor it already analyze and factorize the matrix.
Don't do it twice.

If we give a matrix to the SparseLU ctor it already
analyze and factorize the matrix.
Don't do it twice.
@alkino alkino requested a review from pramodk December 12, 2023 09:50
Copy link

sonarcloud bot commented Dec 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

src/ivoc/ocmatrix.cpp Show resolved Hide resolved
Copy link

✔️ 19f63c2 -> Azure artifacts URL

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b087a92) 66.20% compared to head (19f63c2) 66.20%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2639      +/-   ##
==========================================
- Coverage   66.20%   66.20%   -0.01%     
==========================================
  Files         559      559              
  Lines      108955   108956       +1     
==========================================
- Hits        72132    72130       -2     
- Misses      36823    36826       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pramodk pramodk merged commit f71c64e into master Dec 12, 2023
36 checks passed
@pramodk pramodk deleted the twice_is_not_alright branch December 12, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants