Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make have_to_want with templates #2645

Merged
merged 8 commits into from
Jan 8, 2024
Merged

Conversation

alkino
Copy link
Member

@alkino alkino commented Dec 20, 2023

This pull request try to clean have_to_want algorithm:

  • Having a hpp file instead of cpp file,
  • Use template so that the algorithm can be included twice,
  • Remove usage of 3 configurations variables by preprocessor (before the algorithm was paramretrized by preprocessor variable leading to some weird inclusion),
  • Use std::vector<> instead of new T*,
  • Create a new structure Data to group data, count and displ.

Should the structure Data be move in MPI code and be accepted by the interface itself?

Should we found a better name for this structure ^^?

Copy link

✔️ 4d97ee7 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 1979d3d -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 8b0b0bc -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ b782b1b -> Azure artifacts URL

Copy link

✔️ 1ac1f95 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 6c34480 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

@alkino alkino requested a review from pramodk December 22, 2023 14:14
Copy link

✔️ f70c2ae -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@alkino alkino closed this Jan 3, 2024
@alkino alkino reopened this Jan 3, 2024
Copy link

✔️ f70c2ae -> Azure artifacts URL

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d2c8c4b) 66.20% compared to head (cdc85b5) 66.19%.

Files Patch % Lines
src/nrniv/have2want.hpp 96.34% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2645      +/-   ##
==========================================
- Coverage   66.20%   66.19%   -0.01%     
==========================================
  Files         559      559              
  Lines      108957   108939      -18     
==========================================
- Hits        72132    72112      -20     
- Misses      36825    36827       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the structure Data be move in MPI code and be accepted by the interface itself?
Should we found a better name for this structure ^^?

It's local / used in one file, right? In that case, don't have a strong opinion for both questions.

src/nrniv/partrans.cpp Outdated Show resolved Hide resolved
Copy link

✔️ e187b1b -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented Jan 7, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

8 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ cdc85b5 -> Azure artifacts URL

Copy link
Member

@pramodk pramodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alkino alkino merged commit 1e0d8be into master Jan 8, 2024
37 checks passed
@alkino alkino deleted the cornu/have_to_want_template branch January 8, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants