-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make have_to_want with templates #2645
Conversation
50749cb
to
4d97ee7
Compare
✔️ 4d97ee7 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
76baeff
to
1979d3d
Compare
✔️ 1979d3d -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 8b0b0bc -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
8b0b0bc
to
b782b1b
Compare
✔️ b782b1b -> Azure artifacts URL |
✔️ 1ac1f95 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ 6c34480 -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
58d4b7a
to
f70c2ae
Compare
✔️ f70c2ae -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
✔️ f70c2ae -> Azure artifacts URL |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2645 +/- ##
==========================================
- Coverage 66.20% 66.19% -0.01%
==========================================
Files 559 559
Lines 108957 108939 -18
==========================================
- Hits 72132 72112 -20
- Misses 36825 36827 +2 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the structure Data be move in MPI code and be accepted by the interface itself?
Should we found a better name for this structure ^^?
It's local / used in one file, right? In that case, don't have a strong opinion for both questions.
✔️ e187b1b -> Azure artifacts URL |
This comment has been minimized.
This comment has been minimized.
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 8 New issues |
✔️ cdc85b5 -> Azure artifacts URL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request try to clean
have_to_want
algorithm:hpp
file instead ofcpp
file,std::vector<>
instead ofnew T*
,Data
to groupdata
,count
anddispl
.Should the structure
Data
be move in MPI code and be accepted by the interface itself?Should we found a better name for this structure ^^?