Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cell builder session files involving extracellular could not be saved. #2651

Merged
merged 1 commit into from
Jan 7, 2024

Conversation

nrnhines
Copy link
Member

@nrnhines nrnhines commented Jan 6, 2024

Closes #2649

@nrnhines nrnhines requested a review from 1uc January 6, 2024 15:59
Copy link

sonarcloud bot commented Jan 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

✔️ 494a0d7 -> Azure artifacts URL

Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (2cf7248) 66.19% compared to head (494a0d7) 66.19%.

Files Patch % Lines
src/ivoc/datapath.cpp 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2651   +/-   ##
=======================================
  Coverage   66.19%   66.19%           
=======================================
  Files         559      559           
  Lines      108956   108958    +2     
=======================================
+ Hits        72126    72128    +2     
  Misses      36830    36830           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pramodk
Copy link
Member

pramodk commented Jan 7, 2024

I just re-ran the failing gpu CI test and all is green.

@pramodk pramodk merged commit b045e50 into master Jan 7, 2024
37 checks passed
@pramodk pramodk deleted the hines/extracellular-session branch January 7, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

master bug : could not translate legacy index 10
3 participants