Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize DECREF (part 4). #3208

Merged
merged 12 commits into from
Nov 18, 2024
Merged

Modernize DECREF (part 4). #3208

merged 12 commits into from
Nov 18, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Nov 14, 2024

Needs rebasing, but conflicts with part 3.

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (54f5f7b) to head (1c5d9eb).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_p2h.cpp 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3208      +/-   ##
==========================================
- Coverage   67.08%   67.07%   -0.01%     
==========================================
  Files         569      569              
  Lines      111190   111175      -15     
==========================================
- Hits        74590    74576      -14     
+ Misses      36600    36599       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

✔️ 42cd898 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ f8a396f -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

@1uc 1uc marked this pull request as ready for review November 14, 2024 19:30
src/nrnpython/nrnpy_p2h.cpp Outdated Show resolved Hide resolved
@bbpbuildbot

This comment has been minimized.

Copy link

✔️ d793761 -> Azure artifacts URL

Copy link

sonarcloud bot commented Nov 18, 2024

Copy link

✔️ 1c5d9eb -> Azure artifacts URL

@1uc 1uc merged commit 3aec743 into master Nov 18, 2024
35 checks passed
@1uc 1uc deleted the 1uc/modernize-decref-4 branch November 18, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants