Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize DECREF (part 7). #3218

Merged
merged 17 commits into from
Nov 21, 2024
Merged

Modernize DECREF (part 7). #3218

merged 17 commits into from
Nov 21, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Nov 18, 2024

No description provided.

Copy link

✔️ 50e86e0 -> Azure artifacts URL

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 32.55814% with 29 lines in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (cc3acde) to head (dd02fcc).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_hoc.cpp 32.55% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3218      +/-   ##
==========================================
- Coverage   67.07%   67.07%   -0.01%     
==========================================
  Files         569      569              
  Lines      111143   111141       -2     
==========================================
- Hits        74551    74549       -2     
  Misses      36592    36592              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bbpbuildbot

This comment has been minimized.

src/nrnpython/nrnpy_hoc.cpp Outdated Show resolved Hide resolved
src/nrnpython/nrnpy_hoc.cpp Show resolved Hide resolved
@ferdonline
Copy link
Member

I don't see any functional changes. LGTM

@1uc 1uc marked this pull request as ready for review November 20, 2024 14:31
@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 48a1cfa -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ e5d45e5 -> Azure artifacts URL

Copy link

sonarcloud bot commented Nov 21, 2024

Copy link

✔️ dd02fcc -> Azure artifacts URL

@1uc 1uc merged commit 7f38f75 into master Nov 21, 2024
35 checks passed
@1uc 1uc deleted the 1uc/modernize-decref-7 branch November 21, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants