-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify with the new nb::bytearray #3230
Conversation
Very nice work. Let's fix the leak and then apply this modernization: (just in case nanobind does something weird, it'll be nice to know if it's refcounting related or not.) |
95e4fbe
to
649d4a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll need to remember to rebase outstanding PRs diligently to make sure they run against the new version of nanobind.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3230 +/- ##
==========================================
- Coverage 67.07% 67.07% -0.01%
==========================================
Files 569 569
Lines 111155 111150 -5
==========================================
- Hits 74559 74554 -5
Misses 36596 36596 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
✔️ 649d4a4 -> Azure artifacts URL |
Quality Gate passedIssues Measures |
✔️ 3824d9c -> Azure artifacts URL |
No description provided.