Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify with the new nb::bytearray #3230

Merged
merged 3 commits into from
Nov 20, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 20, 2024

No description provided.

@1uc
Copy link
Collaborator

1uc commented Nov 20, 2024

Very nice work. Let's fix the leak and then apply this modernization:
#3229

(just in case nanobind does something weird, it'll be nice to know if it's refcounting related or not.)

@alkino alkino force-pushed the origin/cornu/nanobind/dump_and_bytearray branch from 95e4fbe to 649d4a4 Compare November 20, 2024 13:09
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to remember to rebase outstanding PRs diligently to make sure they run against the new version of nanobind.

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.07%. Comparing base (e8255b9) to head (3824d9c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3230      +/-   ##
==========================================
- Coverage   67.07%   67.07%   -0.01%     
==========================================
  Files         569      569              
  Lines      111155   111150       -5     
==========================================
- Hits        74559    74554       -5     
  Misses      36596    36596              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

✔️ 649d4a4 -> Azure artifacts URL

@alkino alkino enabled auto-merge (squash) November 20, 2024 14:14
Copy link

sonarcloud bot commented Nov 20, 2024

Copy link

✔️ 3824d9c -> Azure artifacts URL

@alkino alkino merged commit a8a53a2 into master Nov 20, 2024
35 checks passed
@alkino alkino deleted the origin/cornu/nanobind/dump_and_bytearray branch November 20, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants