Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nb::make_tuple #3232

Merged
merged 3 commits into from
Nov 20, 2024
Merged

Use nb::make_tuple #3232

merged 3 commits into from
Nov 20, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 20, 2024

No description provided.

src/nrnpython/nrnpy_p2h.cpp Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 20, 2024

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.07%. Comparing base (e8255b9) to head (0061929).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_p2h.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3232   +/-   ##
=======================================
  Coverage   67.07%   67.07%           
=======================================
  Files         569      569           
  Lines      111155   111151    -4     
=======================================
- Hits        74559    74557    -2     
+ Misses      36596    36594    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

✔️ 0061929 -> Azure artifacts URL

@alkino alkino enabled auto-merge (squash) November 20, 2024 16:39
@alkino alkino merged commit a8b882b into master Nov 20, 2024
35 checks passed
@alkino alkino deleted the origin/cornu/nanobind/use_make_tuple branch November 20, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants