Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify hocpickle_reduce #3233

Merged
merged 10 commits into from
Nov 21, 2024
Merged

Simplify hocpickle_reduce #3233

merged 10 commits into from
Nov 21, 2024

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 20, 2024

No description provided.

@alkino alkino enabled auto-merge (squash) November 20, 2024 16:52
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.08%. Comparing base (bbdcd39) to head (48de5be).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_hoc.cpp 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3233      +/-   ##
==========================================
- Coverage   67.08%   67.08%   -0.01%     
==========================================
  Files         569      569              
  Lines      111130   111113      -17     
==========================================
- Hits        74554    74541      -13     
+ Misses      36576    36572       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 9280833 -> Azure artifacts URL

src/nrnpython/nrnpy_hoc.cpp Outdated Show resolved Hide resolved
src/nrnpython/nrnpy_hoc.cpp Outdated Show resolved Hide resolved
src/nrnpython/nrnpy_hoc.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@1uc 1uc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice chunk of C API gone.

Copy link

sonarcloud bot commented Nov 21, 2024

Copy link

✔️ 48de5be -> Azure artifacts URL

@alkino alkino merged commit 973c723 into master Nov 21, 2024
35 checks passed
@alkino alkino deleted the origin/cornu/nanobind/hocpickle branch November 21, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants