Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize DECREF (part 9). #3234

Merged
merged 23 commits into from
Nov 26, 2024
Merged

Modernize DECREF (part 9). #3234

merged 23 commits into from
Nov 26, 2024

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Nov 20, 2024

No description provided.

@1uc 1uc force-pushed the 1uc/modernize-decref-9 branch 2 times, most recently from 37defa8 to ef51fb2 Compare November 20, 2024 17:39
@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 87.00000% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.08%. Comparing base (eded2de) to head (b060441).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_utils.cpp 83.07% 11 Missing ⚠️
src/nrnpython/rxd.cpp 71.42% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3234   +/-   ##
=======================================
  Coverage   67.07%   67.08%           
=======================================
  Files         569      570    +1     
  Lines      111079   111067   -12     
=======================================
+ Hits        74511    74512    +1     
+ Misses      36568    36555   -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bbpbuildbot

This comment has been minimized.

@bbpbuildbot

This comment has been minimized.

Copy link

✔️ 0335998 -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Copy link

sonarcloud bot commented Nov 25, 2024

Copy link

✔️ b060441 -> Azure artifacts URL

@1uc 1uc marked this pull request as ready for review November 25, 2024 10:45
@1uc 1uc merged commit fa7d530 into master Nov 26, 2024
35 checks passed
@1uc 1uc deleted the 1uc/modernize-decref-9 branch November 26, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants