Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py_ functions should take and return nb objects #3236

Closed
wants to merge 2 commits into from
Closed

py_ functions should take and return nb objects #3236

wants to merge 2 commits into from

Conversation

alkino
Copy link
Member

@alkino alkino commented Nov 21, 2024

After Modernize MPI

@bbpbuildbot

This comment has been minimized.

Sign in to view
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #239001 (:no_entry:) have been uploaded here!

Status and direct links:

1uc
1uc previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@1uc 1uc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. However, these functions are likely registered with Python as callbacks and therefore need to return PyObject*.

@1uc 1uc dismissed their stale review November 21, 2024 13:32

CI says it doesn't work.

@alkino alkino closed this Nov 21, 2024
@alkino alkino deleted the cornu/nb/py_ branch November 21, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1uc 1uc 1uc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alkino @bbpbuildbot @1uc