Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernize DECREF (part 10). #3240

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Modernize DECREF (part 10). #3240

wants to merge 19 commits into from
+161 −126

Conversation

1uc
Copy link
Collaborator

@1uc 1uc commented Nov 21, 2024

This covers a number of instances related to nrnpy_ho2po. Maybe of these are function that accept a new reference and pass it on.

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.09924% with 30 lines in your changes missing coverage. Please review.

Project coverage is 67.09%. Comparing base (eded2de) to head (c438312).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/nrnpython/nrnpy_hoc.cpp 70.40% 29 Missing ⚠️
src/nrnpython/nrnpy_nrn.cpp 96.96% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3240      +/-   ##
==========================================
+ Coverage   67.07%   67.09%   +0.01%     
==========================================
  Files         569      569              
  Lines      111079   111095      +16     
==========================================
+ Hits        74511    74534      +23     
+ Misses      36568    36561       -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@azure-pipelines Azure Pipelines
Copy link

✔️ b30434d -> Azure artifacts URL

@bbpbuildbot

This comment has been minimized.

Sign in to view
@1uc
Document reference type.
185f552
@1uc
Modernize DECREF in segment_getattro (result).
ea91c6e
@1uc
Modernize DECREF in pysec2cell (result).
841f92d
@1uc
Document reference type.
c1aae05
@1uc
Modernize DECREF in mech_getattro (result).
77f9651
@1uc
Document reference type.
d7683d3
@1uc
Modernize DECREF in nrnpy_hoc_pop (result).
b84046a
@1uc
Modernize DECREF in cpp2refstr (result).
97deefa
@1uc
Modernize DECREF in intermediate (ponew).
c91cc8e
@1uc
Modernize DECREF in hocobj_getsec (result).
5062b09
@1uc
Comment on reference type.
56e62e0
@1uc
nullptr
cbd842e
@1uc
Modernize DECREF in hocobj_getattr (result).
9f28ff2
@1uc
Modernize DECREF in hocobj_iter (po2).
e66ece5
@1uc
Modernize DECREF in hocobj_iter (self).
cf3de7d
@1uc
nullptr etc.
b006df4
@1uc
Modernize DECREF in hocobj_getitem.
69e43d1
@1uc
nullptr
e422a56
@1uc
Modernize DECREF in get_plotshape_data (py_sl, py_obj).
c438312
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
5.0% Duplication on New Code

See analysis details on SonarQube Cloud

@azure-pipelines Azure Pipelines
Copy link

✔️ c438312 -> Azure artifacts URL

@1uc 1uc marked this pull request as ready for review November 25, 2024 10:45
@bbpbuildbot
Copy link
Collaborator

Logfiles from GitLab pipeline #239221 (:no_entry:) have been uploaded here!

Status and direct links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alkino alkino alkino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@1uc @bbpbuildbot @alkino