Fix thread sanitizer leak when launching Python 3.13 and using from neuron import h, gui. #3243
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3243 +/- ##
==========================================
- Coverage 67.08% 67.08% -0.01%
==========================================
Files 569 569
Lines 111079 111091 +12
==========================================
+ Hits 74520 74525 +5
- Misses 36559 36566 +7 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
✔️ be19ebe -> Azure artifacts URL |
| This allows one to temporarily disable the process_events loop using a construct | ||
| like: | ||
| from neuron import gui | ||
| with gui.disabled(): | ||
| something_that_would_interact_badly_with_process_events() | ||
| """ |
There was a problem hiding this comment.
I don't know if this is still current, but if so, it should either stay here, or be moved to the docstring of disabled below. If it's not current, just ignore this comment.
| @@ -208,11 +208,20 @@ static int have_opt(const char* arg) { | |||
| } | |||
|
|
|||
| void nrnpython_finalize() { | |||
| printf("nrnpython_finalize()\n"); | |||
There was a problem hiding this comment.
Maybe put behind an #ifndef NDEBUG, or a comment?
|
No description provided.