Place results in subdirs #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kousu
force-pushed
the
output-subdirs
branch
2 times, most recently
from
1d5d889
to
5c7289b
Compare
kousu
force-pushed
the
shorten-env
branch
2 times, most recently
from
9ca56aa
to
6d9aec7
Compare
kousu
force-pushed
the
output-subdirs
branch
from
5c7289b
to
0598331
Compare
kousu
commented
Feb 25, 2023
| if err != nil { | ||
| return stateError, err | ||
| } | ||
| stdout, err := os.OpenFile(resultPath, os.O_CREATE|os.O_TRUNC|os.O_WRONLY, 0640) |
There was a problem hiding this comment.
I slipped in changing the permissions here to mimic the 0750 on the directory.
Draft
Subdirs are simply named by taking the prefix of the input UUID. This is a common technique to prevent the chance of overflowing filesystem limits on the number of files allowed in a single directory. e.g. Before - /srv/gitea/custom/public/90fa9a89-5e50-4bd4-834d-d42655e1ee8e.html - http://127.0.0.1:3000/assets/90fa9a89-5e50-4bd4-834d-d42655e1ee8e.html After: - /srv/gitea/custom/public/bids-validator/84/b1/84b10e1c-b188-41e2-a92d-fb6ded9c6889.html - http://127.0.0.1:3000/assets/bids-validator/84/b1/84b10e1c-b188-41e2-a92d-fb6ded9c6889.html
kousu
force-pushed
the
output-subdirs
branch
from
0598331
to
adba766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subdirs are simply named by taking the prefix of the input UUID.
This is a common technique to prevent the chance of overflowing filesystem limits on the number of files allowed in a single directory.
e.g.
Before
After:
** Follows #6 **