Upgrade upload-artifact to v4

neurostuff · Sep 10, 2024 · f8a8e87 · f8a8e87
1 parent f1c7c4b
commit f8a8e87
Showing 1 changed file with 62 additions and 54 deletions.
diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
@@ -6,7 +6,7 @@ on:
       - "main"
   pull_request:
     branches:
-      - '*'
+      - "*"
 
 concurrency:
   group: testing-${{ github.ref }}
@@ -26,37 +26,37 @@ jobs:
       - id: result_step
         uses: mstachniuk/ci-skip@master
         with:
-          commit-filter: '[skip ci];[ci skip];[skip github]'
-          commit-filter-separator: ';'
+          commit-filter: "[skip ci];[ci skip];[skip github]"
+          commit-filter-separator: ";"
 
   run_unit_tests:
     name: Unit tests
     needs: check_skip
     if: ${{ needs.check_skip.outputs.skip == 'false' }}
     runs-on: ${{ matrix.os }}
     strategy:
-        fail-fast: false
-        matrix:
-            os: ["ubuntu-latest", "macos-latest"]
-            python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
+      fail-fast: false
+      matrix:
+        os: ["ubuntu-latest", "macos-latest"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
 
     defaults:
       run:
         shell: bash
     steps:
       - uses: actions/checkout@v2
-      - name: 'Set up python'
+      - name: "Set up python"
         uses: actions/setup-python@v2
         with:
-            python-version: ${{ matrix.python-version }}
-      - name: 'Install NiMARE'
+          python-version: ${{ matrix.python-version }}
+      - name: "Install NiMARE"
         shell: bash {0}
         run: pip install -e .[tests,cbmr]
-      - name: 'Run tests'
+      - name: "Run tests"
         shell: bash {0}
         run: make unittest
       - name: Upload artifacts
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: unit_${{ matrix.os }}_${{ matrix.python-version }}
           path: coverage.xml
@@ -68,27 +68,27 @@ jobs:
     if: ${{ needs.check_skip.outputs.skip == 'false' }}
     runs-on: ${{ matrix.os }}
     strategy:
-        fail-fast: false
-        matrix:
-            os: ["ubuntu-latest"]
-            python-version: ["3.8"]
+      fail-fast: false
+      matrix:
+        os: ["ubuntu-latest"]
+        python-version: ["3.8"]
     defaults:
       run:
         shell: bash
     steps:
       - uses: actions/checkout@v2
-      - name: 'Set up python'
+      - name: "Set up python"
         uses: actions/setup-python@v2
         with:
-            python-version: 3.8
-      - name: 'Install NiMARE'
+          python-version: 3.8
+      - name: "Install NiMARE"
         shell: bash {0}
         run: pip install -e .[minimum,tests,cbmr]
-      - name: 'Run tests'
+      - name: "Run tests"
         shell: bash {0}
         run: make unittest
       - name: Upload artifacts
-        uses: actions/upload-artifact@v2
+        uses: actions/upload-artifact@v4
         with:
           name: unit_minimum
           path: coverage.xml
@@ -100,23 +100,23 @@ jobs:
     if: ${{ needs.check_skip.outputs.skip == 'false' }}
     runs-on: ${{ matrix.os }}
     strategy:
-        fail-fast: false
-        matrix:
-            os: ["ubuntu-latest"]
-            python-version: ["3.8"]
+      fail-fast: false
+      matrix:
+        os: ["ubuntu-latest"]
+        python-version: ["3.8"]
     defaults:
       run:
         shell: bash
     steps:
       - uses: actions/checkout@v2
-      - name: 'Set up python'
+      - name: "Set up python"
         uses: actions/setup-python@v2
         with:
-            python-version: ${{ matrix.python-version }}
-      - name: 'Install NiMARE'
+          python-version: ${{ matrix.python-version }}
+      - name: "Install NiMARE"
         shell: bash {0}
         run: pip install -e .[tests,cbmr]
-      - name: 'Run tests'
+      - name: "Run tests"
         shell: bash {0}
         run: make test_performance_estimators
       - name: Upload artifacts
@@ -132,23 +132,23 @@ jobs:
     if: ${{ needs.check_skip.outputs.skip == 'false' }}
     runs-on: ${{ matrix.os }}
     strategy:
-        fail-fast: false
-        matrix:
-            os: ["ubuntu-latest"]
-            python-version: ["3.8"]
+      fail-fast: false
+      matrix:
+        os: ["ubuntu-latest"]
+        python-version: ["3.8"]
     defaults:
       run:
         shell: bash
     steps:
       - uses: actions/checkout@v2
-      - name: 'Set up python'
+      - name: "Set up python"
         uses: actions/setup-python@v2
         with:
-            python-version: ${{ matrix.python-version }}
-      - name: 'Install NiMARE'
+          python-version: ${{ matrix.python-version }}
+      - name: "Install NiMARE"
         shell: bash {0}
         run: pip install -e .[tests,cbmr]
-      - name: 'Run tests'
+      - name: "Run tests"
         shell: bash {0}
         run: make test_performance_correctors
       - name: Upload artifacts
@@ -164,23 +164,23 @@ jobs:
     if: ${{ needs.check_skip.outputs.skip == 'false' }}
     runs-on: ${{ matrix.os }}
     strategy:
-        fail-fast: false
-        matrix:
-            os: ["ubuntu-latest"]
-            python-version: ["3.8"]
+      fail-fast: false
+      matrix:
+        os: ["ubuntu-latest"]
+        python-version: ["3.8"]
     defaults:
       run:
         shell: bash
     steps:
       - uses: actions/checkout@v2
-      - name: 'Set up python'
+      - name: "Set up python"
         uses: actions/setup-python@v2
         with:
-            python-version: ${{ matrix.python-version }}
-      - name: 'Install NiMARE'
+          python-version: ${{ matrix.python-version }}
+      - name: "Install NiMARE"
         shell: bash {0}
         run: pip install -e .[tests,cbmr]
-      - name: 'Run tests'
+      - name: "Run tests"
         shell: bash {0}
         run: make test_performance_smoke
       - name: Upload artifacts
@@ -196,23 +196,23 @@ jobs:
     if: ${{ needs.check_skip.outputs.skip == 'false' }}
     runs-on: ${{ matrix.os }}
     strategy:
-        fail-fast: false
-        matrix:
-            os: ["ubuntu-latest"]
-            python-version: ["3.8"]
+      fail-fast: false
+      matrix:
+        os: ["ubuntu-latest"]
+        python-version: ["3.8"]
     defaults:
       run:
         shell: bash
     steps:
       - uses: actions/checkout@v2
-      - name: 'Set up python'
+      - name: "Set up python"
         uses: actions/setup-python@v2
         with:
-            python-version: ${{ matrix.python-version }}
-      - name: 'Install NiMARE'
+          python-version: ${{ matrix.python-version }}
+      - name: "Install NiMARE"
         shell: bash {0}
         run: pip install -e .[tests]
-      - name: 'Run tests'
+      - name: "Run tests"
         shell: bash {0}
         run: make test_cbmr_importerror
       - name: Upload artifacts
@@ -224,7 +224,15 @@ jobs:
 
   upload_to_codecov:
     name: Upload coverage
-    needs: [run_unit_tests,run_unit_tests_with_minimum_dependencies,test_performance_estimators,test_performance_correctors,test_performance_smoke,test_cbmr_importerror]
+    needs:
+      [
+        run_unit_tests,
+        run_unit_tests_with_minimum_dependencies,
+        test_performance_estimators,
+        test_performance_correctors,
+        test_performance_smoke,
+        test_cbmr_importerror,
+      ]
     runs-on: "ubuntu-latest"
     steps:
       - name: Checkout