-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nimads
module with implementations of NIMADS objects
#628
Conversation
Codecov ReportBase: 88.64% // Head: 84.67% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
==========================================
- Coverage 88.64% 84.67% -3.97%
==========================================
Files 38 43 +5
Lines 4324 4693 +369
==========================================
+ Hits 3833 3974 +141
- Misses 491 719 +228
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
"""Point to a new location for image files on the local filesystem.""" | ||
... | ||
|
||
def get_analyses_by_coordinates(self, xyz, r=None, n=None): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The get*
methods can be removed, since they'll be in DatasetSearcher
in the future (post #677).
@jdkent would you be willing to link any issues this should close? |
Co-authored-by: Taylor Salo <[email protected]>
This will probably never be merged, so I will say that it references #218 instead of closes it. I just wanted to put together a skeleton of the
nimads
module, so that we can determine what's necessary vs. optional and what might be difficult to implement in NiMARE.