Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nimads module with implementations of NIMADS objects #628

Closed
wants to merge 21 commits into from

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Dec 22, 2021

This will probably never be merged, so I will say that it references #218 instead of closes it. I just wanted to put together a skeleton of the nimads module, so that we can determine what's necessary vs. optional and what might be difficult to implement in NiMARE.

nimare/nimads.py Show resolved Hide resolved
@tsalo tsalo added enhancement New feature or request neurostore Issues and PRs related to NeuroStore compatibility. labels Feb 12, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Base: 88.64% // Head: 84.67% // Decreases project coverage by -3.97% ⚠️

Coverage data is based on head (910037e) compared to base (282f197).
Patch coverage: 68.02% of modified lines in pull request are covered.

❗ Current head 910037e differs from pull request most recent head 8c4d359. Consider uploading reports for the commit 8c4d359 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   88.64%   84.67%   -3.97%     
==========================================
  Files          38       43       +5     
  Lines        4324     4693     +369     
==========================================
+ Hits         3833     3974     +141     
- Misses        491      719     +228     
Impacted Files Coverage Δ
nimare/nimads.py 64.22% <64.22%> (ø)
nimare/workflows/neurosynth_compose.py 69.23% <69.23%> (ø)
nimare/io.py 95.37% <100.00%> (+0.22%) ⬆️
nimare/workflows/__init__.py 100.00% <100.00%> (ø)
nimare/meta/utils.py 54.29% <0.00%> (-41.44%) ⬇️
nimare/meta/kernel.py 80.12% <0.00%> (-15.67%) ⬇️
nimare/extract/extract.py 42.97% <0.00%> (-4.90%) ⬇️
nimare/meta/cbma/ale.py 94.92% <0.00%> (-1.70%) ⬇️
nimare/meta/cbma/mkda.py 97.08% <0.00%> (-1.68%) ⬇️
nimare/meta/cbma/base.py 95.63% <0.00%> (-0.39%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jdkent
Copy link
Member

jdkent commented Apr 26, 2022

ref neurostuff/neurostore#269

"""Point to a new location for image files on the local filesystem."""
...

def get_analyses_by_coordinates(self, xyz, r=None, n=None):
Copy link
Member Author

@tsalo tsalo Apr 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The get* methods can be removed, since they'll be in DatasetSearcher in the future (post #677).

nimare/nimads.py Outdated Show resolved Hide resolved
@tsalo
Copy link
Member Author

tsalo commented Jul 1, 2022

@jdkent would you be willing to link any issues this should close?

@tsalo tsalo modified the milestone: 0.0.14 Jan 17, 2023
@tsalo tsalo added this to the 0.1.0 milestone Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request neurostore Issues and PRs related to NeuroStore compatibility.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants