Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resample argument from IBMA estimators #823

Merged
merged 10 commits into from
Aug 22, 2023

Conversation

JulioAPeraza
Copy link
Collaborator

Related to #817.

Currently if resample=False we get an error if at least one image has shape/affines different from the mask. In this case, users will have to run an IBMA again with resample=True even if most images don't need to be resampled.

Changes proposed in this pull request:

  • In this PR we remove that burden from users and perform the resampling only if the shape/affines are different.
  • Also, we are removing the memory_limit argument, given that use_memmap decorator is not being used by IBMA estimators.

@JulioAPeraza JulioAPeraza added enhancement New feature or request ibma Issues/PRs pertaining to image-based meta-analysis labels Aug 16, 2023
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02% ⚠️

Comparison is base (e59a083) 88.68% compared to head (1843993) 88.67%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #823      +/-   ##
==========================================
- Coverage   88.68%   88.67%   -0.02%     
==========================================
  Files          47       47              
  Lines        6026     6020       -6     
==========================================
- Hits         5344     5338       -6     
  Misses        682      682              
Files Changed Coverage Δ
nimare/meta/ibma.py 99.57% <100.00%> (-0.02%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulioAPeraza JulioAPeraza mentioned this pull request Aug 22, 2023
Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jdkent jdkent merged commit dd8f89c into neurostuff:main Aug 22, 2023
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ibma Issues/PRs pertaining to image-based meta-analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants