-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add correction for multiple contrasts within a study in Stouffer's IBMA #882
Conversation
if you merge in main, that should fix the codecov errors you are seeing! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #882 +/- ##
==========================================
- Coverage 88.22% 88.15% -0.07%
==========================================
Files 48 48
Lines 6352 6367 +15
==========================================
+ Hits 5604 5613 +9
- Misses 748 754 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, np.tile may blow up the memory usage, looking into an alternative.
EDIT: it does not appear to have a large impact, but we can revisit changing the API.
That's a good point. I tried to pass a 1D array since the groups and weights are the same across voxels, but PyMARE didn't allow that. |
Closes None.
Changes proposed in this pull request: