Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add correction for multiple contrasts within a study in Stouffer's IBMA #882

Merged
merged 6 commits into from
May 22, 2024

Conversation

JulioAPeraza
Copy link
Collaborator

Closes None.

Changes proposed in this pull request:

@JulioAPeraza JulioAPeraza added the enhancement New feature or request label Apr 19, 2024
@JulioAPeraza JulioAPeraza marked this pull request as ready for review April 30, 2024 21:20
@jdkent jdkent mentioned this pull request May 4, 2024
@jdkent
Copy link
Member

jdkent commented May 6, 2024

if you merge in main, that should fix the codecov errors you are seeing!

Copy link

codecov bot commented May 6, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.15%. Comparing base (ac9792d) to head (e4ce01e).
Report is 16 commits behind head on main.

Files Patch % Lines
nimare/meta/ibma.py 72.72% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #882      +/-   ##
==========================================
- Coverage   88.22%   88.15%   -0.07%     
==========================================
  Files          48       48              
  Lines        6352     6367      +15     
==========================================
+ Hits         5604     5613       +9     
- Misses        748      754       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JulioAPeraza JulioAPeraza requested a review from jdkent May 17, 2024 19:19
Copy link
Member

@jdkent jdkent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, np.tile may blow up the memory usage, looking into an alternative.

EDIT: it does not appear to have a large impact, but we can revisit changing the API.

@JulioAPeraza
Copy link
Collaborator Author

That's a good point. I tried to pass a 1D array since the groups and weights are the same across voxels, but PyMARE didn't allow that.
In the end, we only use the information from one voxel: https://github.com/neurostuff/PyMARE/blob/master/pymare/estimators/combination.py#L145-L146

@jdkent jdkent merged commit 0f7446b into neurostuff:main May 22, 2024
20 checks passed
@JulioAPeraza JulioAPeraza deleted the enh-stouffer branch May 22, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants