Merge pull request #761 from neutron-org/fix/remove-tmp-dir

fix: really removes tmp dir after cli run

cmd/neutrond/root.go

@@ -51,6 +51,9 @@ func NewRootCmd() (*cobra.Command, params.EncodingConfig) {
 	// create a temporary application for use in constructing query + tx commands
 	initAppOptions := viper.New()
 	tempDir := tempDir()
+	// cleanup temp dir after we are done with the tempApp, so we don't leave behind a
+	// new temporary directory for every invocation. See https://github.com/CosmWasm/wasmd/issues/2017
+	defer os.RemoveAll(tempDir)
 	initAppOptions.Set(flags.FlagHome, tempDir)
 	tempApplication := app.New(
 		log.NewNopLogger(),
@@ -139,7 +142,6 @@ func tempDir() string {
 	if err != nil {
 		dir = app.DefaultNodeHome
 	}
-	defer os.RemoveAll(dir)
 
 	return dir
 }