Merge duality neutron (CORRECT BRANCH) #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
November 1, 2023 15:21
the version of packet-forward-middleware being used by neutron breaks duality's swap-and-forward middleware due to a change in how receiever addresses are handled.
cleanup KeeperTestHelper and re-use for dex testing centralize event testing assertions rename test suite to be more informative
duality code requires max gas to be set initChain panics
In order to simulate more realistic trade volume and avoid inadvertent failures due to ErrInvalidPositionSpread all of the basic user operations (fundXXXBalance, assertXXXBalance, XXXLimitsSells, etc.) treat TokenA and TokenB as BIG tokens with an exponent of 6. Ie. fundAliceBalance(10, 10) funds alices account with 10,000,000 small TokenA and TokenB. For tests requiring more accuracy methods that take Ints (ie. assertXXXAccountBalancesInt, NewWithdrawlInt) are used and assume that amount are being provided in terms of small tokens. Example: s.fundAliceBalances(10, 10) s.assertAliceBalances(10, 10) ==> True s.assertAliceBalancesInt(sdkmath.NewInt(10_000_000), sdkmath.NewInt(10_000_000)) ==> true
-typos, -remove extra maccperms -remove unused expected keepers -incorrect module for burning coins for ibcswap -adding minting restriction for dex
Closed
added 4 commits
November 1, 2023 15:34
every sdk.Coin.Add happening in DepositCore results in multiple traversals over all coins in sharesIssued , and also involves allocation of additional data structures, thus resulting in quadratic scaling of the DepositCore runtime (because it invokes sdk.Coins Add() for each issued share).
Much better gas efficiency since we don't need to perform duplicate lookups for each share issuance Also add additional check for duplicate deposits. This should exist regardless but also required for share math to work if we aren't issuing shares within the deposit loop
swelf19
reviewed
Nov 2, 2023
Fix/revert pfm upgrade
…e->snake_case camelCase -> snake_case
Add simple gmp ibcswap test
revert PFM reversions. Disable PFM for ibcswap
This was referenced Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge duality modules (dex, epochs, gmp, ibcswap & incentives) into neutron.