Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cli): remove ValidateBasic in cli #406

Merged
merged 1 commit into from
Jan 12, 2024
Merged

refactor(cli): remove ValidateBasic in cli #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions x/dex/client/cli/tx_cancel_limit_order.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ func CmdCancelLimitOrder() *cobra.Command {
clientCtx.GetFromAddress().String(),
args[0],
)
if err := msg.ValidateBasic(); err != nil {
return err
}

return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
},
Expand Down
3 changes: 0 additions & 3 deletions x/dex/client/cli/tx_deposit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,6 @@ func CmdDeposit() *cobra.Command {
FeesUint,
DepositOptions,
)
if err := msg.ValidateBasic(); err != nil {
return err
}

return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
},
Expand Down
3 changes: 0 additions & 3 deletions x/dex/client/cli/tx_multi_hop_swap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@ func CmdMultiHopSwap() *cobra.Command {
exitLimitPriceDec,
pickBest,
)
if err := msg.ValidateBasic(); err != nil {
return err
}

return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
},
Expand Down
3 changes: 0 additions & 3 deletions x/dex/client/cli/tx_place_limit_order.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,6 @@ func CmdPlaceLimitOrder() *cobra.Command {
goodTil,
maxAmountOutIntP,
)
if err := msg.ValidateBasic(); err != nil {
return err
}

return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
},
Expand Down
3 changes: 0 additions & 3 deletions x/dex/client/cli/tx_withdrawl.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,6 @@ func CmdWithdrawal() *cobra.Command {
TicksIndexesInt,
FeesUint,
)
if err := msg.ValidateBasic(); err != nil {
return err
}

return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
},
Expand Down
3 changes: 0 additions & 3 deletions x/dex/client/cli/tx_withdrawl_filled_limit_order.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,6 @@ func CmdWithdrawFilledLimitOrder() *cobra.Command {
clientCtx.GetFromAddress().String(),
args[0],
)
if err := msg.ValidateBasic(); err != nil {
return err
}

return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), msg)
},
Expand Down
7 changes: 0 additions & 7 deletions x/interchainqueries/client/cli/tx.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,6 @@ func RemoveInterchainQueryCmd() *cobra.Command {
}

msg := types.NewMsgRemoveInterchainQuery(sender, queryID)
if err = msg.ValidateBasic(); err != nil {
return err
}

return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), &msg)
},
Expand Down Expand Up @@ -92,10 +89,6 @@ func SubmitQueryResultCmd() *cobra.Command {
return fmt.Errorf("failed to unmarshal query result: %w", err)
}

if err = msg.ValidateBasic(); err != nil {
return err
}

return tx.GenerateOrBroadcastTxCLI(clientCtx, cmd.Flags(), &msg)
},
}
Expand Down
Loading