Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: dex event cleanup #NTRN-367 #648

Merged
merged 4 commits into from
Aug 20, 2024
Merged

Conversation

jcompagni10
Copy link
Contributor

@jcompagni10 jcompagni10 commented Jul 31, 2024

For easier indexing of dex events it is helpful for all core dex messages to have a receiver field.

Also used the opportunity to refactor the event keys for greater consistency and clarity.

@jcompagni10
Copy link
Contributor Author

Copy link
Collaborator

@pr0n00gler pr0n00gler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR going to break some integration?
Like, existing indexers, etc

I remember there was a complaint about changes in DEX API in one of our recent upgrades

@jcompagni10
Copy link
Contributor Author

Is this PR going to break some integration? Like, existing indexers, etc

I remember there was a complaint about changes in DEX API in one of our recent upgrades

No keys have been changed. I've just added a receiver field to withdraw and cancel limit order.

@pr0n00gler pr0n00gler merged commit e109821 into main Aug 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants