Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RBS/Steep type-declarations and checking #28

Merged
merged 8 commits into from
Nov 14, 2023
Merged

Add RBS/Steep type-declarations and checking #28

merged 8 commits into from
Nov 14, 2023

Commits on Nov 14, 2023

  1. Test and make explicit the behavior of ENV.array with a nil default 

    This was behaving correctly before, but only because Array(nil) is [],
which might surprise some people (as it did me).
    @nevinera
    nevinera committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    79f4174 View commit details
    Browse the repository at this point in the history

  2. Stub without_env - tests should pass even if that env is actually set

    @nevinera
    nevinera committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    41f9c5c View commit details
    Browse the repository at this point in the history

  3. short-circuit parse_range_from when text is nil 

    The behavior was already correct (and tested as such), since nil =~ _
returns nil, but this skips the method and is easier to follow.
    @nevinera
    nevinera committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    c8905f5 View commit details
    Browse the repository at this point in the history

  4. convert the symbol default to a string default to reuse ENV.string 

    This is just to satisfy the type-checker
    @nevinera
    nevinera committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    061e18d View commit details
    Browse the repository at this point in the history

  5. Add Steep, Steepfile, and passing signatures

    @nevinera
    nevinera committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    51b5c13 View commit details
    Browse the repository at this point in the history

  6. Add a workflow to run steep

    @nevinera
    nevinera committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    657cf57 View commit details
    Browse the repository at this point in the history

  7. remove the redundant current directory path (rubocop)

    @nevinera
    nevinera committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    a454764 View commit details
    Browse the repository at this point in the history

  8. Don't include steep in the dev-deps 

    instead, put it in the Gemfile, and allow an ENV to exclude it, which we
can then supply in the rspec github actions. We need to run tests in
environments that steep doesn't support, and gemspecs don't (as yet)
support optional dev dependencies.
    @nevinera
    nevinera committed Nov 14, 2023
    Configuration menu
    Copy the full SHA
    40a118f View commit details
    Browse the repository at this point in the history