Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support reading redis config from env vars (optionally with prefix) #20

Merged
merged 1 commit into from
Feb 26, 2024
Merged

feat: support reading redis config from env vars (optionally with prefix) #20

merged 1 commit into from
Feb 26, 2024

Conversation

sdewitt-newrelic
Copy link
Contributor

Adds

  • Moved DataCache to it's own file
  • Don't use noops in DataCache if cache disabled
  • Added config class supporting reading config from config file then auto env vars then default
  • Updated AuthEnv to use new config class
  • Updated integration.py to use new config class
  • Updated salesforce.py to use new cache
  • Various minor changes

@sdewitt-newrelic sdewitt-newrelic self-assigned this Feb 23, 2024
@sdewitt-newrelic sdewitt-newrelic added the enhancement New feature or request label Feb 23, 2024
@sdewitt-newrelic sdewitt-newrelic linked an issue Feb 23, 2024 that may be closed by this pull request
Support Redis configuration from environment variables #16
Closed
asllop
asllop approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@asllop asllop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor.

@asllop asllop merged commit 0c795f7 into main Feb 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asllop asllop asllop approved these changes

Assignees

@sdewitt-newrelic sdewitt-newrelic

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Redis configuration from environment variables
2 participants
@sdewitt-newrelic @asllop