Step2 : 기능구현 #151
Open
Step2 : 기능구현 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 일부 빌더 패턴 적용 - 많은 곳에서 add 메소드가 있어서 추가하는 방향으로 개선
- 메소드를 분리해 가독성을 향상 시킨다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 리뷰어님~
오랜만에 pr을 보내네요~
저번 리뷰 받은 부분 적용과 요금 정책을 추가했습니다~
Path에서 요금 계산을 시키려다 보니 이전 리뷰 주신 내용처럼 또 종속이 되어 버렸습니다.. ㅠ
path를 생성할 때 외부에서 주입하려면 subwayMap에서 넣어줘야 한다고 생각이 되었습니다.
이렇게 되면 subwayMap에서 몰라도 되는 요금 관련 정책을 안다고 생각되어 내부에서 생성하도록 하였습니다
항상 리뷰 감사드립니다~