[Spring Core] 안정현 미션제출합니다. #76
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoToBILL
reviewed
Jul 9, 2024
| public JwtUtil jwtUtil() { | ||
| return new JwtUtil(secret, expiration); | ||
| } | ||
| } |
There was a problem hiding this comment.
저도 이거를 고민했는데 roomescape내의 패키지로 auth를 만들 경우, 이게 맞는데 미션에서 동등한 계층이라는 말이 있어서 저는 java밑의 계층의 패키지로 만들어주었습니다. 그럴 경우 @import를 사용해서 외부 컴포넌트 스캔 범위를 벗어나는 경우를 스캔 할 수 있더라구요!
GoToBILL
reviewed
Jul 9, 2024
| registry.addInterceptor(adminInterceptor) | ||
| .addPathPatterns("/admin/**"); | ||
| } | ||
| } |
There was a problem hiding this comment.
interceptor와 argumentResolver의 역할이 맥락적으로 같다고 생각해서 같은 config안에 등록해주는 건 어떨까요?
GoToBILL
reviewed
Jul 9, 2024
| reservationRepository.save(new Reservation(admin.getId(), "2024-03-01", theme3.getId(), time3.getId())); | ||
| reservationRepository.save(new Reservation(brown.getId(), "2024-03-01", theme2.getId(), time1.getId())); | ||
| } | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요! 리뷰어님.
미션 자체는 저번보다 괜찮았지만, 7단계 분리하는 부분에서 제가 잘 분리한게 맞는지.. 하는 의심이 듭니다.
이 부분에 관해서 의견 주시면 감사할 것 같습니다!
7, 8단계