-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spring Core] 남해윤 미션 제출합니다. #391
Open
haeyoon1
wants to merge
14
commits into
next-step:haeyoon1
Choose a base branch
from
haeyoon1:haeyoon-core
base: haeyoon1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Gradle 수정 - HomeController, ReservationController 생성 - Reservation dto 생성
- ReservationController속 변수에 값 넣어준 코드 주석처리
- h2 데이터베이스를 활용하여 데이터를 저장하도록 수정
- 예약 조회 API 처리 로직에서 저장된 예약을 조회할 때 데이터베이스를 활용하도록 수정
- 예약 추가/취소 API 처리 로직에서 데이터베이스를 활용하도록 수정
- time 관련 controller, dao, dto, entity, repository, service 추가
-reservation time의 문자형을 Time형으로 수정
- 테이블 스키마 재정의 - 예약 클래스 시간 타입 Time으로 수정 - 예약 쿼리 수정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요 원태연 리뷰어님! 리뷰 잘 부탁 드립니다!
지난주에 다른 리뷰어님께서 time의 자료형을 String이 아니라 LocalTime으로 변경해보라는 리뷰를 남겨주셔서 그렇게 변경해 보았는데 이번주 미션에서 오류가 너무 많이 나더라고요 .. 원래 조건대로 String형태로 지정하는 것이 나을까요?
그리고 최대한 코드를 수정해보았는데 9단계 미션부터 오류가 나서 실행되지 않습니다.... 추가로 더 수정해서 다시 pr올리도록 하겠습니다 ㅠㅠ 또한 어느부분이 잘못됐는지 궁금합니다. 늦게 제출하여 죄송합니다. 리뷰 잘 부탁드립니다! 감사합니다.